Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 1952933002: DevTools: extract the report view to reuse in app manifest and service worker pane. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests fixed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
index fe34672a418a7c0a769ef559dd0ac0534b92463f..c2146ab67d7ef80e0f13c921b15e5e669c00aba4 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
@@ -506,50 +506,6 @@ WebInspector.linkifyStringAsFragment = function(string)
/**
* @param {string} url
- * @param {string=} linkText
- * @param {string=} classes
- * @param {boolean=} isExternal
- * @param {string=} tooltipText
- * @return {!Element}
- */
-WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, tooltipText)
-{
- if (!linkText)
- linkText = url;
-
- var a = createElementWithClass("a", classes);
- var href = url;
- if (url.trim().toLowerCase().startsWith("javascript:"))
- href = null;
- if (isExternal && WebInspector.ParsedURL.isRelativeURL(url))
- href = null;
- if (href !== null) {
- a.href = href;
- a.classList.add(isExternal ? "webkit-html-external-link" : "webkit-html-resource-link");
- }
- if (!tooltipText && linkText !== url)
- a.title = url;
- else if (tooltipText)
- a.title = tooltipText;
- a.textContent = linkText.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayedURLs);
- if (isExternal)
- a.setAttribute("target", "_blank");
-
- return a;
-}
-
-/**
- * @param {string} article
- * @param {string} title
- * @return {!Element}
- */
-WebInspector.linkifyDocumentationURLAsNode = function(article, title)
-{
- return WebInspector.linkifyURLAsNode("https://developers.google.com/web/tools/chrome-devtools/" + article, title, undefined, true);
-}
-
-/**
- * @param {string} url
* @param {number=} lineNumber
* @param {number=} columnNumber
* @param {string=} classes

Powered by Google App Engine
This is Rietveld 408576698