third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h - Issue 1952893003: Implement custom element construction and some 'define' checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not expose CustomElementsRegistry to isolated worlds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h b/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h

index f2b6cf6aec092c4b51a7eb637baa045d6942e1df..f2e3017b0df274d9d4b17c37c557e01f3250ad06 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h

@@ -42,8 +42,9 @@

namespace blink {

-class V0CustomElementConstructorBuilder;

class ExceptionState;

+class ScriptState;

+class V0CustomElementConstructorBuilder;

class V0CustomElementRegistry final {

WTF_MAKE_NONCOPYABLE(V0CustomElementRegistry);

@@ -51,13 +52,14 @@ class V0CustomElementRegistry final {

public:

DECLARE_TRACE();

void documentWasDetached() { m_documentWasDetached = true; }

+ bool nameIsDefined(const AtomicString&) const;

protected:

friend class V0CustomElementRegistrationContext;

V0CustomElementRegistry() : m_documentWasDetached(false) { }

- V0CustomElementDefinition* registerElement(Document*, V0CustomElementConstructorBuilder*, const AtomicString& name, V0CustomElement::NameSet validNames, ExceptionState&);

+ V0CustomElementDefinition* registerElement(ScriptState*, Document*, V0CustomElementConstructorBuilder*, const AtomicString& name, V0CustomElement::NameSet validNames, ExceptionState&);

V0CustomElementDefinition* find(const V0CustomElementDescriptor&) const;

private: