third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp - Issue 1952893003: Implement custom element construction and some 'define' checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp

Issue 1952893003: Implement custom element construction and some 'define' checks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not expose CustomElementsRegistry to isolated worlds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.h ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp

index ee05a67de77277b8085aa68f9e3992ac67012031..0a0fcd3c7e71cbf0e369960cfade0517ae7f5987 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistrationContext.cpp

@@ -49,9 +49,9 @@ V0CustomElementRegistrationContext::V0CustomElementRegistrationContext()

{

}

-void V0CustomElementRegistrationContext::registerElement(Document* document, V0CustomElementConstructorBuilder* constructorBuilder, const AtomicString& type, V0CustomElement::NameSet validNames, ExceptionState& exceptionState)

+void V0CustomElementRegistrationContext::registerElement(ScriptState* scriptState, Document* document, V0CustomElementConstructorBuilder* constructorBuilder, const AtomicString& type, V0CustomElement::NameSet validNames, ExceptionState& exceptionState)

{

- V0CustomElementDefinition* definition = m_registry.registerElement(document, constructorBuilder, type, validNames, exceptionState);

+ V0CustomElementDefinition* definition = m_registry.registerElement(scriptState, document, constructorBuilder, type, validNames, exceptionState);

if (!definition)

return;