chrome/android/java/res/layout/sync_error_widget.xml - Issue 1952853005: Surface sync error icon in account settings UI if sync error

Unified Diff: chrome/android/java/res/layout/sync_error_widget.xml

Issue 1952853005: Surface sync error icon in account settings UI if sync error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/sync_error.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/sync_error_widget.xml

diff --git a/chrome/android/java/res/layout/sync_error_widget.xml b/chrome/android/java/res/layout/sync_error_widget.xml

new file mode 100644

index 0000000000000000000000000000000000000000..66b681c33bec1c95d9fab083dc4d105c0068276a

--- /dev/null

+++ b/chrome/android/java/res/layout/sync_error_widget.xml

@@ -0,0 +1,11 @@

+<?xml version="1.0" encoding="utf-8"?>

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<ImageView

+ xmlns:android="http://schemas.android.com/apk/res/android"

+ android:layout_width="wrap_content"

+ android:layout_height="wrap_content"

+ android:src="@drawable/sync_error"/>

Bernhard Bauer 2016/05/09 13:58:06 Should we add a textual description for accessibil

gogerald1 2016/05/09 16:51:59 Done.

Bernhard Bauer 2016/05/10 09:12:45 It's a good comment, but I was talking about acces

gogerald1 2016/05/11 15:09:24 Done.