chrome/android/java/res/layout/sync_error_widget.xml - Issue 1952853005: Surface sync error icon in account settings UI if sync error

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/sync_error_widget.xml

Issue 1952853005: Surface sync error icon in account settings UI if sync error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/sync_error.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <ImageView

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="wrap_content"

	9 android:layout_height="wrap_content"

	10 android:src="@drawable/sync_error"/>
	Bernhard Bauer 2016/05/09 13:58:06 Should we add a textual description for accessibil Should we add a textual description for accessibility? gogerald1 2016/05/09 16:51:59 Done. Show quoted text On 2016/05/09 13:58:06, Bernhard Bauer wrote: > Should we add a textual description for accessibility? Done. Bernhard Bauer 2016/05/10 09:12:45 It's a good comment, but I was talking about acces Show quoted text On 2016/05/09 16:51:59, gogerald1 wrote: > On 2016/05/09 13:58:06, Bernhard Bauer wrote: > > Should we add a textual description for accessibility? > > Done. It's a good comment, but I was talking about accessibility. In this particular case, we should make sure that we don't exclusively rely on the error icon being visible, because some users might not be able to see that icon (well, or at all), and might for example have to rely on a screen reader. That will require a textual representation though. go/android-a11y has some more information about accessibility. gogerald1 2016/05/11 15:09:24 Done. Show quoted text On 2016/05/10 09:12:45, Bernhard Bauer wrote: > On 2016/05/09 16:51:59, gogerald1 wrote: > > On 2016/05/09 13:58:06, Bernhard Bauer wrote: > > > Should we add a textual description for accessibility? > > > > Done. > > It's a good comment, but I was talking about accessibility. In this particular > case, we should make sure that we don't exclusively rely on the error icon being > visible, because some users might not be able to see that icon (well, or at > all), and might for example have to rely on a screen reader. That will require a > textual representation though. go/android-a11y has some more information about > accessibility. Done.
	11

OLD	NEW