Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move more things to Node::create() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp b/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
index 783e2cfd9d975a89ee66f6996a58a0952d021c30..b5c5b7f5689f79da41f8a6a08c9ed7df8edac992 100644
--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
@@ -39,6 +39,18 @@ WaveShaperNode::WaveShaperNode(AbstractAudioContext& context)
handler().initialize();
}
+WaveShaperNode* WaveShaperNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)
hongchan 2016/05/13 01:20:13 Let's wrap arguments.
+{
+ ASSERT(isMainThread());
hongchan 2016/05/13 01:20:13 DCHECK.
Raymond Toy 2016/05/20 23:12:01 Done.
+
+ if (context.isContextClosed()) {
+ context.throwExceptionForClosedState(exceptionState);
+ return nullptr;
+ }
+
+ return new WaveShaperNode(context);
+}
+
WaveShaperProcessor* WaveShaperNode::getWaveShaperProcessor() const
{
return static_cast<WaveShaperProcessor*>(static_cast<AudioBasicProcessorHandler&>(handler()).processor());

Powered by Google App Engine
This is Rietveld 408576698