Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move more things to Node::create() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
index de4c8ceb38b68b67ce5006af59a475d023f635d4..5c1caabf3adf65ed03f0939256908bf3513c1ca6 100644
--- a/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
@@ -134,16 +134,23 @@ void StereoPannerHandler::setChannelCountMode(const String& mode, ExceptionState
// ----------------------------------------------------------------
-StereoPannerNode::StereoPannerNode(AbstractAudioContext& context, float sampleRate)
+StereoPannerNode::StereoPannerNode(AbstractAudioContext& context)
: AudioNode(context)
, m_pan(AudioParam::create(context, ParamTypeStereoPannerPan, 0))
{
- setHandler(StereoPannerHandler::create(*this, sampleRate, m_pan->handler()));
+ setHandler(StereoPannerHandler::create(*this, context.sampleRate(), m_pan->handler()));
hongchan 2016/05/13 01:20:13 80 cols.
}
-StereoPannerNode* StereoPannerNode::create(AbstractAudioContext& context, float sampleRate)
+StereoPannerNode* StereoPannerNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)
hongchan 2016/05/13 01:20:13 Let's wrap arguments.
{
- return new StereoPannerNode(context, sampleRate);
+ ASSERT(isMainThread());
hongchan 2016/05/13 01:20:13 DCHECK.
Raymond Toy 2016/05/20 23:12:01 Done.
+
+ if (context.isContextClosed()) {
+ context.throwExceptionForClosedState(exceptionState);
+ return nullptr;
+ }
+
+ return new StereoPannerNode(context);
}
DEFINE_TRACE(StereoPannerNode)

Powered by Google App Engine
This is Rietveld 408576698