Move the exception logic to the AudioNode creator

third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/webaudio/StereoPannerNode.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "modules/webaudio/AbstractAudioContext.h"
@@ skipping 116 matching lines @@
         // Do nothing for other invalid values.
         m_newChannelCountMode = oldMode;
     }
 
     if (m_newChannelCountMode != oldMode)
         context()->deferredTaskHandler().addChangedChannelCountMode(this);
 }
 
 // ----------------------------------------------------------------
 
-StereoPannerNode::StereoPannerNode(AbstractAudioContext& context, float sampleRate)
+StereoPannerNode::StereoPannerNode(AbstractAudioContext& context)
     : AudioNode(context)
     , m_pan(AudioParam::create(context, ParamTypeStereoPannerPan, 0))
 {
-    setHandler(StereoPannerHandler::create(*this, sampleRate, m_pan->handler()));
+    setHandler(StereoPannerHandler::create(*this, context.sampleRate(), m_pan->handler()));

[hongchan, 2016/05/13 01:20:13]

80 cols.

 }
 
-StereoPannerNode* StereoPannerNode::create(AbstractAudioContext& context, float sampleRate)
+StereoPannerNode* StereoPannerNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)

[hongchan, 2016/05/13 01:20:13]

Let's wrap arguments.

 {
-    return new StereoPannerNode(context, sampleRate);
+    ASSERT(isMainThread());

[hongchan, 2016/05/13 01:20:13]

DCHECK.

[Raymond Toy, 2016/05/20 23:12:01]

Done.

+
+    if (context.isContextClosed()) {
+        context.throwExceptionForClosedState(exceptionState);
+        return nullptr;
+    }
+
+    return new StereoPannerNode(context);
 }
 
 DEFINE_TRACE(StereoPannerNode)
 {
     visitor->trace(m_pan);
     AudioNode::trace(visitor);
 }
 
 AudioParam* StereoPannerNode::pan() const
 {
     return m_pan;
 }
 
 } // namespace blink