Chromium Code Reviews| Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp |
| diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp |
| index dd77f7ba62780d07d1bdf980f8390e06ed525b65..7edc90f1903aaacc3e2e17d9f1e72012a96cc158 100644 |
| --- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp |
| +++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp |
| @@ -125,7 +125,7 @@ double DynamicsCompressorHandler::latencyTime() const |
| // ---------------------------------------------------------------- |
| -DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, float sampleRate) |
| +DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context) |
| : AudioNode(context) |
| , m_threshold(AudioParam::create(context, ParamTypeDynamicsCompressorThreshold, -24)) |
| , m_knee(AudioParam::create(context, ParamTypeDynamicsCompressorKnee, 30)) |
| @@ -135,7 +135,7 @@ DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, fl |
| { |
| setHandler(DynamicsCompressorHandler::create( |
| *this, |
| - sampleRate, |
| + context.sampleRate(), |
| m_threshold->handler(), |
| m_knee->handler(), |
| m_ratio->handler(), |
| @@ -143,9 +143,16 @@ DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, fl |
| m_release->handler())); |
| } |
| -DynamicsCompressorNode* DynamicsCompressorNode::create(AbstractAudioContext& context, float sampleRate) |
| +DynamicsCompressorNode* DynamicsCompressorNode::create(AbstractAudioContext& context, ExceptionState& exceptionState) |
| { |
| - return new DynamicsCompressorNode(context, sampleRate); |
| + ASSERT(isMainThread()); |
|
hongchan
2016/05/13 01:20:12
DCHECK.
Raymond Toy
2016/05/20 23:12:00
Done.
|
| + |
| + if (context.isContextClosed()) { |
| + context.throwExceptionForClosedState(exceptionState); |
| + return nullptr; |
| + } |
| + |
| + return new DynamicsCompressorNode(context); |
| } |
| DEFINE_TRACE(DynamicsCompressorNode) |