Move the exception logic to the AudioNode creator

third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

 /*
  * Copyright (C) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 107 matching lines @@
     return m_dynamicsCompressor->tailTime();
 }
 
 double DynamicsCompressorHandler::latencyTime() const
 {
     return m_dynamicsCompressor->latencyTime();
 }
 
 // ----------------------------------------------------------------
 
-DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, float sampleRate)
+DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context)
     : AudioNode(context)
     , m_threshold(AudioParam::create(context, ParamTypeDynamicsCompressorThreshold, -24))
     , m_knee(AudioParam::create(context, ParamTypeDynamicsCompressorKnee, 30))
     , m_ratio(AudioParam::create(context, ParamTypeDynamicsCompressorRatio, 12))
     , m_attack(AudioParam::create(context, ParamTypeDynamicsCompressorAttack, 0.003))
     , m_release(AudioParam::create(context, ParamTypeDynamicsCompressorRelease, 0.250))
 {
     setHandler(DynamicsCompressorHandler::create(
         *this,
-        sampleRate,
+        context.sampleRate(),
         m_threshold->handler(),
         m_knee->handler(),
         m_ratio->handler(),
         m_attack->handler(),
         m_release->handler()));
 }
 
-DynamicsCompressorNode* DynamicsCompressorNode::create(AbstractAudioContext& context, float sampleRate)
+DynamicsCompressorNode* DynamicsCompressorNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)
 {
-    return new DynamicsCompressorNode(context, sampleRate);
+    ASSERT(isMainThread());

[hongchan, 2016/05/13 01:20:12]

DCHECK.

[Raymond Toy, 2016/05/20 23:12:00]

Done.

+
+    if (context.isContextClosed()) {
+        context.throwExceptionForClosedState(exceptionState);
+        return nullptr;
+    }
+
+    return new DynamicsCompressorNode(context);
 }
 
 DEFINE_TRACE(DynamicsCompressorNode)
 {
     visitor->trace(m_threshold);
     visitor->trace(m_knee);
     visitor->trace(m_ratio);
     visitor->trace(m_attack);
     visitor->trace(m_release);
     AudioNode::trace(visitor);
@@ skipping 29 matching lines @@
     return m_attack;
 }
 
 AudioParam* DynamicsCompressorNode::release() const
 {
     return m_release;
 }
 
 } // namespace blink