third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/DelayNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

index a098272ede2d6030b5c7b26be9cd2a65ae31411c..6eb63ca7555f8e84eaf1c2e27aa8a8d07da41378 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

@@ -81,7 +81,7 @@ private:

class MODULES_EXPORT DynamicsCompressorNode final : public AudioNode {

DEFINE_WRAPPERTYPEINFO();

public:

- static DynamicsCompressorNode* create(AbstractAudioContext&, float sampleRate);

+ static DynamicsCompressorNode* create(AbstractAudioContext&, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

AudioParam* threshold() const;

@@ -92,7 +92,7 @@ public:

AudioParam* release() const;

private:

- DynamicsCompressorNode(AbstractAudioContext&, float sampleRate);

+ DynamicsCompressorNode(AbstractAudioContext&);

DynamicsCompressorHandler& dynamicsCompressorHandler() const;

Member<AudioParam> m_threshold;