Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
index 63b5dad09d7297cbcb822686ba7352b0be92a0b0..b259ddba0ef5ae654d8f3a5dfab2fd3002320b61 100644
--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
@@ -125,7 +125,7 @@ double DynamicsCompressorHandler::latencyTime() const
// ----------------------------------------------------------------
-DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, float sampleRate)
+DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context)
: AudioNode(context)
, m_threshold(AudioParam::create(context, ParamTypeDynamicsCompressorThreshold, -24, -100, 0))
, m_knee(AudioParam::create(context, ParamTypeDynamicsCompressorKnee, 30, 0, 40))
@@ -135,7 +135,7 @@ DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, fl
{
setHandler(DynamicsCompressorHandler::create(
*this,
- sampleRate,
+ context.sampleRate(),
m_threshold->handler(),
m_knee->handler(),
m_ratio->handler(),
@@ -143,9 +143,16 @@ DynamicsCompressorNode::DynamicsCompressorNode(AbstractAudioContext& context, fl
m_release->handler()));
}
-DynamicsCompressorNode* DynamicsCompressorNode::create(AbstractAudioContext& context, float sampleRate)
+DynamicsCompressorNode* DynamicsCompressorNode::create(AbstractAudioContext& context, ExceptionState& exceptionState)
{
- return new DynamicsCompressorNode(context, sampleRate);
+ DCHECK(isMainThread());
+
+ if (context.isContextClosed()) {
+ context.throwExceptionForClosedState(exceptionState);
+ return nullptr;
+ }
+
+ return new DynamicsCompressorNode(context);
}
DEFINE_TRACE(DynamicsCompressorNode)

Powered by Google App Engine
This is Rietveld 408576698