third_party/WebKit/Source/modules/webaudio/DelayNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DelayNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/DelayNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/DelayNode.h b/third_party/WebKit/Source/modules/webaudio/DelayNode.h

index 03d01889136b2ab82fad2c38bb9068f789b1beb9..a697871a2e48ba4d3f71552a3a09442fdfbd45e6 100644

--- a/third_party/WebKit/Source/modules/webaudio/DelayNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/DelayNode.h

@@ -35,12 +35,13 @@ class ExceptionState;

class DelayNode final : public AudioNode {

DEFINE_WRAPPERTYPEINFO();

public:

- static DelayNode* create(AbstractAudioContext&, float sampleRate, double maxDelayTime, ExceptionState&);

+ static DelayNode* create(AbstractAudioContext&, ExceptionState&);

+ static DelayNode* create(AbstractAudioContext&, double maxDelayTime, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

AudioParam* delayTime();

private:

- DelayNode(AbstractAudioContext&, float sampleRate, double maxDelayTime);

+ DelayNode(AbstractAudioContext&, double maxDelayTime);

Member<AudioParam> m_delayTime;

};