third_party/WebKit/Source/modules/webaudio/DelayNode.h - Issue 1952793002: Move the exception logic to the AudioNode creator

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/DelayNode.h

Issue 1952793002: Move the exception logic to the AudioNode creator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010, Google Inc. All rights reserved.	2 * Copyright (C) 2010, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 17 matching lines...) Expand all Loading...
28 #include "modules/webaudio/AudioNode.h"	28 #include "modules/webaudio/AudioNode.h"

29	29

30 namespace blink {	30 namespace blink {

31	31

32 class AbstractAudioContext;	32 class AbstractAudioContext;

33 class ExceptionState;	33 class ExceptionState;

34	34

35 class DelayNode final : public AudioNode {	35 class DelayNode final : public AudioNode {

36 DEFINE_WRAPPERTYPEINFO();	36 DEFINE_WRAPPERTYPEINFO();

37 public:	37 public:

38 static DelayNode* create(AbstractAudioContext&, float sampleRate, double max DelayTime, ExceptionState&);	38 static DelayNode* create(AbstractAudioContext&, ExceptionState&);

	39 static DelayNode* create(AbstractAudioContext&, double maxDelayTime, Excepti onState&);

39 DECLARE_VIRTUAL_TRACE();	40 DECLARE_VIRTUAL_TRACE();

40 AudioParam* delayTime();	41 AudioParam* delayTime();

41	42

42 private:	43 private:

43 DelayNode(AbstractAudioContext&, float sampleRate, double maxDelayTime);	44 DelayNode(AbstractAudioContext&, double maxDelayTime);

44	45

45 Member<AudioParam> m_delayTime;	46 Member<AudioParam> m_delayTime;

46 };	47 };

47	48

48 } // namespace blink	49 } // namespace blink

49	50

50 #endif // DelayNode_h	51 #endif // DelayNode_h

OLD	NEW