Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1952723002: [Smart Lock] Stop showing auto signin first run only after user decision received. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Stop showing auto signin first run only after user decision received. BUG=609135 Committed: https://crrev.com/8c60b4a72614ac2a44e45c8d4f3c5eb60553a8ef Cr-Commit-Position: refs/heads/master@{#391670}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc View 1 2 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952723002/1
4 years, 7 months ago (2016-05-04 17:01:59 UTC) #2
Mike West
LGTM % nit in code, and s/forst/first/ in the CL description. https://codereview.chromium.org/1952723002/diff/1/chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc File chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc (right): ...
4 years, 7 months ago (2016-05-04 17:25:24 UTC) #5
Mike West
On 2016/05/04 at 17:25:24, Mike West (OOO until the 6th) wrote: > LGTM % nit ...
4 years, 7 months ago (2016-05-04 17:25:59 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 17:45:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952723002/20001
4 years, 7 months ago (2016-05-04 21:27:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 22:46:32 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 22:47:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c60b4a72614ac2a44e45c8d4f3c5eb60553a8ef
Cr-Commit-Position: refs/heads/master@{#391670}

Powered by Google App Engine
This is Rietveld 408576698