chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc - Issue 1952723002: [Smart Lock] Stop showing auto signin first run only after user decision received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc

Issue 1952723002: [Smart Lock] Stop showing auto signin first run only after user decision received. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc

diff --git a/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc b/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc

index 8a0333a9751e312590147d79ab7e7ece36a8543c..e98121e4bf1e1b0eafe159384f32c0356b342ede 100644

--- a/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc

+++ b/chrome/browser/password_manager/auto_signin_first_run_dialog_android_unittest.cc

@@ -41,12 +41,12 @@ PrefService* AutoSigninFirstRunDialogAndroidTest::prefs() {

}

TEST_F(AutoSigninFirstRunDialogAndroidTest,

- CheckResetOfPrefAfterFirstRunMessageWasShown) {

+ CheckPrefValueAfterFirstRunMessageWasShown) {

prefs()->SetBoolean(

password_manager::prefs::kWasAutoSignInFirstRunExperienceShown, false);

std::unique_ptr<AutoSigninFirstRunDialogAndroid> dialog(CreateDialog());

dialog.reset();

- EXPECT_TRUE(prefs()->GetBoolean(

+ EXPECT_FALSE(prefs()->GetBoolean(

password_manager::prefs::kWasAutoSignInFirstRunExperienceShown));

}

« no previous file with comments | « chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc ('k') | no next file » | no next file with comments »