Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1952673002: Revert of Start out deferring commits in WebViewImpl. (Closed)

Created:
4 years, 7 months ago by chrishtr
Modified:
4 years, 7 months ago
Reviewers:
Xianzhu, enne (OOO)
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Start out deferring commits in WebViewImpl. (patchset #2 id:20001 of https://codereview.chromium.org/1934513004/ ) Reason for revert: Caused 608623 and 609033 Original issue's description: > Start out deferring commits in WebViewImpl. > > This is analogous to the call in WebViewImpl::setRootGraphicsLayer when deleting > the root graphics layer (as a proxy for detecting page navigation), but for when > starting up a new WebViewImpl. > > BUG=470669 > > Committed: https://crrev.com/eb72314ba51288a9e0b8b351286a375d6065763f > Cr-Commit-Position: refs/heads/master@{#390865} TBR=wangxianzhu@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=470669, 608623, 609033 Committed: https://crrev.com/d5766b3e7b9476d7427f0f5034352ff0c874abfd Cr-Commit-Position: refs/heads/master@{#391563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
chrishtr
Created Revert of Start out deferring commits in WebViewImpl.
4 years, 7 months ago (2016-05-04 15:05:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 15:05:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 15:32:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 16:02:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 16:32:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 17:01:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 17:31:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 18:02:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952673002/1
4 years, 7 months ago (2016-05-04 18:08:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 18:14:38 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:17:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5766b3e7b9476d7427f0f5034352ff0c874abfd
Cr-Commit-Position: refs/heads/master@{#391563}

Powered by Google App Engine
This is Rietveld 408576698