Issue 1952663007: Fix interstitial ui crashing when open in new tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1952663007: Fix interstitial ui crashing when open in new tab. (Closed)

Created:
4 years, 7 months ago by Jialiu Lin

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Fix interstitial ui crashing when open in new tab. BUG=609003 Review-Url: https://codereview.chromium.org/1955443002 Cr-Commit-Position: refs/heads/master@{#391880} (cherry picked from commit c518abf63a0fdc4b7288f8180997faf0fba0083d) Committed: https://chromium.googlesource.com/chromium/src/+/1e1e317decf02de93a057c0426eb4addaa285a7a

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/ui/webui/interstitials/interstitial_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Jialiu Lin

4 years, 7 months ago (2016-05-06 21:07:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1e1e317decf02de93a057c0426eb4addaa285a7a.