Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(162)

Issue 1952353005: Re-land "Fix invalid using decl in bionic relocation_packer" (Closed)

Created:
3 years, 2 months ago by Reid Kleckner
Modified:
3 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land "Fix invalid using decl in bionic relocation_packer" This time with more namespace qualification. Tested manually by building clang_x64/android_relocation_packer locally, as the Android trybot analyze step does not think it needs to run for this change. Original description: > The code was essentially doing 'using Logger::INFO' in the global > namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does > not allow you to use using decls on classes like this unless you are in > a derived class. GCC does not accept this code, and Clang was recently > updated (LLVM r268594) to reject it as well. > > This should fix the Chromium Android ASan build with TOT Clang: > https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/ TBR=thakis@chromium.org,sgurun@chromium.org BUG=609543 Committed: https://crrev.com/5762af8ad13e62957493c3e4314a234ee57a4200 Cr-Commit-Position: refs/heads/master@{#391952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/bionic/tools/relocation_packer/src/debug.h View 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reid Kleckner
3 years, 2 months ago (2016-05-05 22:52:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952353005/1
3 years, 2 months ago (2016-05-05 22:53:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 2 months ago (2016-05-05 23:44:47 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5762af8ad13e62957493c3e4314a234ee57a4200 Cr-Commit-Position: refs/heads/master@{#391952}
3 years, 2 months ago (2016-05-05 23:47:18 UTC) #6
Nico
3 years, 2 months ago (2016-05-06 14:15:33 UTC) #7
Message was sent while issue was closed.
lgtm

For relands, it's good practice to upload the original change as patch set 1 and
the fixed change as patch set 2, so that it's easy to see what chagned.

Powered by Google App Engine
This is Rietveld 408576698