Re-land "Fix invalid using decl in bionic relocation_packer"

Re-land "Fix invalid using decl in bionic relocation_packer"

This time with more namespace qualification.

Tested manually by building clang_x64/android_relocation_packer locally,
as the Android trybot analyze step does not think it needs to run for
this change.

Original description:

> The code was essentially doing 'using Logger::INFO' in the global
> namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
> not allow you to use using decls on classes like this unless you are in
> a derived class. GCC does not accept this code, and Clang was recently
> updated (LLVM r268594) to reject it as well.
>
> This should fix the Chromium Android ASan build with TOT Clang:
> https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/

TBR=thakis@chromium.org,sgurun@chromium.org
BUG=609543
Committed: https://crrev.com/5762af8ad13e62957493c3e4314a234ee57a4200
Cr-Commit-Position: refs/heads/master@{#391952}

[Reid Kleckner, 2016-05-05 22:52:37]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2016-05-05 22:53:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952353005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952353005/1

[commit-bot: I haz the power, 2016-05-05 23:44:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-05 23:47:17]

Description was changed from

==========
Re-land "Fix invalid using decl in bionic relocation_packer"

This time with more namespace qualification.

Tested manually by building clang_x64/android_relocation_packer locally,
as the Android trybot analyze step does not think it needs to run for
this change.

Original description:

> The code was essentially doing 'using Logger::INFO' in the global
> namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
> not allow you to use using decls on classes like this unless you are in
> a derived class. GCC does not accept this code, and Clang was recently
> updated (LLVM r268594) to reject it as well.
>
> This should fix the Chromium Android ASan build with TOT Clang:
> https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/

TBR=thakis@chromium.org,sgurun@chromium.org
BUG=609543
==========

to

==========
Re-land "Fix invalid using decl in bionic relocation_packer"

This time with more namespace qualification.

Tested manually by building clang_x64/android_relocation_packer locally,
as the Android trybot analyze step does not think it needs to run for
this change.

Original description:

> The code was essentially doing 'using Logger::INFO' in the global
> namespace to make its 'LOG(INFO)' macros work. Unfortunately, C++ does
> not allow you to use using decls on classes like this unless you are in
> a derived class. GCC does not accept this code, and Clang was recently
> updated (LLVM r268594) to reject it as well.
>
> This should fix the Chromium Android ASan build with TOT Clang:
> https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/

TBR=thakis@chromium.org,sgurun@chromium.org
BUG=609543

Committed: https://crrev.com/5762af8ad13e62957493c3e4314a234ee57a4200
Cr-Commit-Position: refs/heads/master@{#391952}
==========

[commit-bot: I haz the power, 2016-05-05 23:47:18]

Patchset 1 (id:??) landed as
https://crrev.com/5762af8ad13e62957493c3e4314a234ee57a4200
Cr-Commit-Position: refs/heads/master@{#391952}

[Nico, 2016-05-06 14:15:33]

lgtm

For relands, it's good practice to upload the original change as patch set 1 and
the fixed change as patch set 2, so that it's easy to see what chagned.