MD Downloads: fix unvulcanized build by adding <style no-process>

MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not
have loaded <link href> inside of shadow DOM (i.imgur.com/Gw9zEVg.png).
So there's a behavioral difference between the vulcanized and
unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the
Polymer team lands a better, more thorough alternative that bypasses the
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/916c6e84f2a975baec9fc965c76653dcbfd939b4
Cr-Commit-Position: refs/heads/master@{#391871}

[Dan Beam, 2016-05-05 00:44:26]

Description was changed from

==========
MD Downloads: fix unvulcanized build

Also unblocks us from sharing --md custom CSS props efficiently between
history and downloads.

R=tsergeant@chromium.org
BUG=608098
==========

to

==========
MD Downloads: fix unvulcanized build

Also unblocks us from sharing --md custom CSS props efficiently between
history and downloads.

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-05 01:31:31]

Description was changed from

==========
MD Downloads: fix unvulcanized build

Also unblocks us from sharing --md custom CSS props efficiently between
history and downloads.

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does
what it says on the tin. But, unfortunately, in this case the
browser would not have loaded <link href> inside of a <template>
because it's inert. So there's a behavioral difference between
the vulcanized and unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed
through Polymer's CSS custom prop shim. In this case, it replaces
unresolved(?) variables with ''. This disables sharing of native
custom properties between history and downloads.

So I've added <style no-process>, which circumvents Polymer's
CSS custom prop shim. It's meant to be a minimal, temporary solution
until the Polymer team lands a better, more thorough alternative
that bypasses the shim everywhere for browser that support CSS
custom props (and possibly @apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-05 01:32:10]

Description was changed from

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does
what it says on the tin. But, unfortunately, in this case the
browser would not have loaded <link href> inside of a <template>
because it's inert. So there's a behavioral difference between
the vulcanized and unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed
through Polymer's CSS custom prop shim. In this case, it replaces
unresolved(?) variables with ''. This disables sharing of native
custom properties between history and downloads.

So I've added <style no-process>, which circumvents Polymer's
CSS custom prop shim. It's meant to be a minimal, temporary solution
until the Polymer team lands a better, more thorough alternative
that bypasses the shim everywhere for browser that support CSS
custom props (and possibly @apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of a <template> because it's inert. So
there's a behavioral difference between the vulcanized and unvulcanized
versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browser that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-05 01:35:26]

Description was changed from

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of a <template> because it's inert. So
there's a behavioral difference between the vulcanized and unvulcanized
versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browser that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of a <template> because it's inert. So
there's a behavioral difference between the vulcanized and unvulcanized
versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-05 01:35:41]

Patchset #1 (id:1) has been deleted

[tsergeant, 2016-05-05 16:38:58]

lgtm, hopefully the permanent solution will arrive soon.

[michaelpg, 2016-05-05 16:51:44]

michaelpg@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-05-05 16:51:44]

https://codereview.chromium.org/1952123002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/manager.html (right):

https://codereview.chromium.org/1952123002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/manager.html:14: <link rel="stylesheet"
href="chrome://resources/css/md_colors.css">
what is the functional difference in moving this link?

in unvulcanized builds, previously it wouldn't fetch the resource until the
template was stamped, and now it fetches the resource at load time?

either way the variables get natively imported, right?

[Dan Beam, 2016-05-05 16:56:57]

Description was changed from

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of a <template> because it's inert. So
there's a behavioral difference between the vulcanized and unvulcanized
versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of shadow DOM (i.imgur.com/Gw9zEVg.png).
So there's a behavioral difference between the vulcanized and
unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-05-05 17:11:54]

Patchset #2 (id:40001) has been deleted

[Dan Beam, 2016-05-05 17:12:01]

https://codereview.chromium.org/1952123002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/manager.html (right):

https://codereview.chromium.org/1952123002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/manager.html:14: <link rel="stylesheet"
href="chrome://resources/css/md_colors.css">
On 2016/05/05 16:51:44, michaelpg wrote:
> what is the functional difference in moving this link?
> 
> in unvulcanized builds, previously it wouldn't fetch the resource until the
> template was stamped, and now it fetches the resource at load time?
> 
> either way the variables get natively imported, right?

http://i.imgur.com/Gw9zEVg.png -> <link> doesn't work in shadow DOM, I've moved
it to a different place in a separate CL here:
https://codereview.chromium.org/1948023004

it so happens that this <link> is also needed by the main page, so it's
previously loaded as well.  but for IWYU purposes, I'm still gonna put it at the
top of this page.

[Dan Beam, 2016-05-05 17:45:51]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-05-05 17:45:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/1952123002/#ps60001
(title: "and vulcanize")

[commit-bot: I haz the power, 2016-05-05 17:46:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1952123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1952123002/60001

[commit-bot: I haz the power, 2016-05-05 19:35:17]

Description was changed from

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of shadow DOM (i.imgur.com/Gw9zEVg.png).
So there's a behavioral difference between the vulcanized and
unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of shadow DOM (i.imgur.com/Gw9zEVg.png).
So there's a behavioral difference between the vulcanized and
unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-05 19:35:18]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-05 19:38:19]

Description was changed from

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not 
have loaded <link href> inside of shadow DOM (i.imgur.com/Gw9zEVg.png).
So there's a behavioral difference between the vulcanized and
unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the 
Polymer team lands a better, more thorough alternative that bypasses the 
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Downloads: fix unvulcanized build by adding <style no-process>

Vulcanize finds <link>s and inlines them. In this sense, it does what it
says on the tin. But, unfortunately, in this case the browser would not
have loaded <link href> inside of shadow DOM (i.imgur.com/Gw9zEVg.png).
So there's a behavioral difference between the vulcanized and
unvulcanized versions of downloads.

Additionally, all <style> inside of <dom-module>s are processed through
Polymer's CSS custom prop shim. In this case, it replaces unresolved(?)
variables with ''. This disables sharing of native custom properties
between history and downloads.

So I've added <style no-process>, which circumvents Polymer's CSS custom
prop shim. It's meant to be a minimal, temporary solution until the
Polymer team lands a better, more thorough alternative that bypasses the
shim everywhere for browsers that support CSS custom props (and possibly
@apply).

R=tsergeant@chromium.org
BUG=608098
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/916c6e84f2a975baec9fc965c76653dcbfd939b4
Cr-Commit-Position: refs/heads/master@{#391871}
==========

[commit-bot: I haz the power, 2016-05-05 19:38:20]

Patchset 2 (id:??) landed as
https://crrev.com/916c6e84f2a975baec9fc965c76653dcbfd939b4
Cr-Commit-Position: refs/heads/master@{#391871}