Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1948023004: MD Downloads: move md_colors.css to useful place (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@no-process
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: move md_colors.css to useful place Previously it was inside shadow DOM, which has no effect. R=michaelpg@chromium.org BUG=608098 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ee1833f510be9a7da4eb75bfecbf4581f71ee193 Cr-Commit-Position: refs/heads/master@{#391909}

Patch Set 1 #

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +14 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Dan Beam
4 years, 7 months ago (2016-05-05 17:12:48 UTC) #2
michaelpg
lgtm
4 years, 7 months ago (2016-05-05 17:17:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948023004/20001
4 years, 7 months ago (2016-05-05 21:14:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 21:37:26 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 21:39:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee1833f510be9a7da4eb75bfecbf4581f71ee193
Cr-Commit-Position: refs/heads/master@{#391909}

Powered by Google App Engine
This is Rietveld 408576698