Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1951863002: Revert of Convert the utility process JSON parser into a Mojo service. (Closed)

Created:
4 years, 7 months ago by Mathieu
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, darin (slow to review), droger+watchlist_chromium.org, qsr+mojo_chromium.org, Robert Sesek, sdefresne+watchlist_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert the utility process JSON parser into a Mojo service. (patchset #13 id:240001 of https://codereview.chromium.org/1861573002/ ) Reason for revert: broke browsertest: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/14012 Original issue's description: > Convert the utility process JSON parser into a Mojo service. > > BUG=597124 > > Committed: https://crrev.com/f8ce981e73207dfb46f6ccbfe2cd29378b3c4baf > Cr-Commit-Position: refs/heads/master@{#391463} TBR=sdefresne@chromium.org,bauerb@chromium.org,thakis@chromium.org,tsepez@chromium.org,amistry@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=597124 Committed: https://crrev.com/3a007c9f5503470c0aa174140b91c0694625a0bc Cr-Commit-Position: refs/heads/master@{#391483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -230 lines) Patch
M chrome/chrome_utility.gypi View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 3 chunks +3 lines, -2 lines 0 comments Download
A chrome/utility/safe_json_parser_handler.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/utility/safe_json_parser_handler.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M components/safe_json.gypi View 3 chunks +6 lines, -19 lines 0 comments Download
M components/safe_json/BUILD.gn View 3 chunks +35 lines, -5 lines 0 comments Download
M components/safe_json/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D components/safe_json/public/interfaces/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D components/safe_json/public/interfaces/safe_json.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D components/safe_json/public/interfaces/safe_json.typemap View 1 chunk +0 lines, -9 lines 0 comments Download
M components/safe_json/safe_json_parser_impl.h View 5 chunks +3 lines, -18 lines 0 comments Download
M components/safe_json/safe_json_parser_impl.cc View 3 chunks +31 lines, -52 lines 0 comments Download
A components/safe_json/safe_json_parser_message_filter.h View 1 chunk +38 lines, -0 lines 0 comments Download
A components/safe_json/safe_json_parser_message_filter.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A components/safe_json/safe_json_parser_messages.h View 1 chunk +35 lines, -0 lines 0 comments Download
A components/safe_json/safe_json_parser_messages.cc View 1 chunk +33 lines, -0 lines 0 comments Download
D components/safe_json/utility/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D components/safe_json/utility/safe_json_parser_mojo_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/safe_json/utility/safe_json_parser_mojo_impl.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D components/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Mathieu
Created Revert of Convert the utility process JSON parser into a Mojo service.
4 years, 7 months ago (2016-05-04 12:12:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951863002/1
4 years, 7 months ago (2016-05-04 12:12:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 12:13:22 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:14:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a007c9f5503470c0aa174140b91c0694625a0bc
Cr-Commit-Position: refs/heads/master@{#391483}

Powered by Google App Engine
This is Rietveld 408576698