Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1951853004: DevTools: allow devtools to skipWaiting service workers. (Closed)

Created:
4 years, 7 months ago by pfeldman
Modified:
4 years, 7 months ago
Reviewers:
caseq, dgozman, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, serviceworker-reviews, tzik, horo+watch_chromium.org, jam, nhiroki, pfeldman+blink_chromium.org, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, kinuko+serviceworker, kinuko+watch, apavlov+blink_chromium.org, lushnikov+blink_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow devtools to skipWaiting service workers. BUG=608997 Committed: https://crrev.com/0ececbac57279663c2b1c7baef492a1b90f9ebb2 Cr-Commit-Position: refs/heads/master@{#391739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 7 months ago (2016-05-05 01:47:35 UTC) #2
caseq
lgtm
4 years, 7 months ago (2016-05-05 01:48:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951853004/1
4 years, 7 months ago (2016-05-05 02:02:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 03:13:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 03:14:51 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0ececbac57279663c2b1c7baef492a1b90f9ebb2
Cr-Commit-Position: refs/heads/master@{#391739}

Powered by Google App Engine
This is Rietveld 408576698