content/browser/devtools/protocol/service_worker_handler.cc - Issue 1951853004: DevTools: allow devtools to skipWaiting service workers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 1951853004: DevTools: allow devtools to skipWaiting service workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/service_worker_handler.h ('k') | content/browser/service_worker/service_worker_context_wrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/service_worker_handler.cc

diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc

index fc6df42eed47789f036c35241357bd2beb5a4798..52a352f38a9a3d6ede8988dc39a6673517b7ad5f 100644

--- a/content/browser/devtools/protocol/service_worker_handler.cc

+++ b/content/browser/devtools/protocol/service_worker_handler.cc

@@ -426,6 +426,15 @@ Response ServiceWorkerHandler::StartWorker(const std::string& scope_url) {

return Response::OK();

}

+Response ServiceWorkerHandler::SkipWaiting(const std::string& scope_url) {

+ if (!enabled_)

+ return Response::OK();

+ if (!context_)

+ return CreateContextErrorResponse();

+ context_->SkipWaitingWorker(GURL(scope_url));

+ return Response::OK();

Response ServiceWorkerHandler::StopWorker(const std::string& version_id) {

if (!enabled_)

return Response::OK();