Issue 19518008: Merged r15610, r15723, r15724, r15725, r15728 into 3.18 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19518008: Merged r15610, r15723, r15724, r15725, r15728 into 3.18 branch. (Closed)

Created:
7 years, 5 months ago by Michael Starzinger

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.18

Visibility:
Public.

More Reviews

Description

Merged r15610, r15723, r15724, r15725, r15728 into 3.18 branch. HasRealIndexedProperty doesn't work on JSGlobalProxy Synchronize Compare-Literal behavior in FullCodegen and Hydrogen There is no undefined Literal. Fix LiteralCompareTypeof breakage introduced in r15723 Better fix for LiteralCompareTypeof R=jkummerow@chromium.org BUG=chromium:257748, chromium:260345 Committed: http://code.google.com/p/v8/source/detail?r=15801

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -114 lines)			Patch
M	src/ast.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ast.cc	View	3 chunks	+15 lines, -7 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+22 lines, -69 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-260345.js	View	1 chunk	+23 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 5 months ago (2013-07-22 11:54:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15801 (presubmit successful).

Expand Messages | Collapse Messages