Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1951773002: [DevTools] add console.time/timeEnd default value for argument (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
paulirish, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] add console.time/timeEnd default value for argument Default value for argument is "default" string. GitHub issue: https://github.com/whatwg/console/issues/54 BUG=608999 R=paulirish@chromium.org,pfeldman@chromium.org Committed: https://crrev.com/6be5eeab85ad5a4569f7ca752149358df83b3393 Cr-Commit-Position: refs/heads/master@{#391718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/inspector/console/console-time.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-time-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
please take a look
4 years, 7 months ago (2016-05-04 04:42:33 UTC) #1
pfeldman
lgtm
4 years, 7 months ago (2016-05-04 22:59:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951773002/1
4 years, 7 months ago (2016-05-04 23:08:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 00:38:46 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 00:39:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6be5eeab85ad5a4569f7ca752149358df83b3393
Cr-Commit-Position: refs/heads/master@{#391718}

Powered by Google App Engine
This is Rietveld 408576698