Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 1951773002: [DevTools] add console.time/timeEnd default value for argument (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-time-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
index e1fc09eb5ada2054d2b1f6e8cec4679f4a5ead08..0eccb8287798b892b54c0b526a988ef069b228e5 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
@@ -373,13 +373,11 @@ static void timeFunction(const v8::FunctionCallbackInfo<v8::Value>& info, bool t
{
ConsoleHelper helper(info);
if (V8DebuggerClient* client = helper.ensureDebuggerClient()) {
- String16 protocolTitle = helper.firstArgToString(String16());
+ String16 protocolTitle = helper.firstArgToString("default");
if (timelinePrefix)
protocolTitle = "Timeline '" + protocolTitle + "'";
client->consoleTime(protocolTitle);
- if (info.Length() < 1)
- return;
v8::Local<v8::Map> timeMap;
if (!helper.privateMap("V8Console#timeMap").ToLocal(&timeMap))
return;
@@ -391,13 +389,11 @@ static void timeEndFunction(const v8::FunctionCallbackInfo<v8::Value>& info, boo
{
ConsoleHelper helper(info);
if (V8DebuggerClient* client = helper.ensureDebuggerClient()) {
- String16 protocolTitle = helper.firstArgToString(String16());
+ String16 protocolTitle = helper.firstArgToString("default");
if (timelinePrefix)
protocolTitle = "Timeline '" + protocolTitle + "'";
client->consoleTimeEnd(protocolTitle);
- if (info.Length() < 1)
- return;
v8::Local<v8::Map> timeMap;
if (!helper.privateMap("V8Console#timeMap").ToLocal(&timeMap))
return;
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-time-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698