[Sync] Clear LocalDeviceInfoProvider cache on sync DB destruction.

[Sync] Clear LocalDeviceInfoProvider cache on sync DB destruction.

Previously this cache would continue returning the old cache GUID and
DeviceInfo, which are no longer valid after directory destruction.

BUG=607287
Committed: https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a
Cr-Commit-Position: refs/heads/master@{#391729}

[maxbogue, 2016-05-04 01:35:03]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2016-05-04 01:35:04]

Pavel, PTAL!

[skym, 2016-05-04 14:48:47]

skym@chromium.org changed reviewers:
+ skym@chromium.org

[skym, 2016-05-04 14:48:48]

lgtm

[pavely, 2016-05-04 22:22:10]

lgtm with one comment.

https://codereview.chromium.org/1951703002/diff/1/components/sync_driver/loca...
File components/sync_driver/local_device_info_provider.h (right):

https://codereview.chromium.org/1951703002/diff/1/components/sync_driver/loca...
components/sync_driver/local_device_info_provider.h:24: class
LocalDeviceInfoProvider : public base::NonThreadSafe {
LocalDeviceInfoProvider is an interface while NonThreadSafe is property of
implementation. I think better way will be to make LocalDeviceInfoProviderImpl
to inherit from NonThreadSafe.

[maxbogue, 2016-05-04 23:19:35]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-05-04 23:19:36]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org,
pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/1951703002/#ps20001
(title: "Move NonThreadSafe to LocalDeviceInfoProviderImpl.")

[maxbogue, 2016-05-04 23:19:47]

https://codereview.chromium.org/1951703002/diff/1/components/sync_driver/loca...
File components/sync_driver/local_device_info_provider.h (right):

https://codereview.chromium.org/1951703002/diff/1/components/sync_driver/loca...
components/sync_driver/local_device_info_provider.h:24: class
LocalDeviceInfoProvider : public base::NonThreadSafe {
On 2016/05/04 22:22:10, pavely wrote:
> LocalDeviceInfoProvider is an interface while NonThreadSafe is property of
> implementation. I think better way will be to make LocalDeviceInfoProviderImpl
> to inherit from NonThreadSafe.

Done.

[commit-bot: I haz the power, 2016-05-04 23:20:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951703002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951703002/20001

[commit-bot: I haz the power, 2016-05-05 02:06:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 02:07:20]

Description was changed from

==========
[Sync] Clear LocalDeviceInfoProvider cache on sync DB destruction.

Previously this cache would continue returning the old cache GUID and
DeviceInfo, which are no longer valid after directory destruction.

BUG=607287
==========

to

==========
[Sync] Clear LocalDeviceInfoProvider cache on sync DB destruction.

Previously this cache would continue returning the old cache GUID and
DeviceInfo, which are no longer valid after directory destruction.

BUG=607287

Committed: https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a
Cr-Commit-Position: refs/heads/master@{#391729}
==========

[commit-bot: I haz the power, 2016-05-05 02:07:21]

Patchset 2 (id:??) landed as
https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a
Cr-Commit-Position: refs/heads/master@{#391729}