Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: components/browser_sync/browser/profile_sync_service_unittest.cc

Issue 1951703002: [Sync] Clear LocalDeviceInfoProvider cache on sync DB destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move NonThreadSafe to LocalDeviceInfoProviderImpl. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_service_unittest.cc
diff --git a/components/browser_sync/browser/profile_sync_service_unittest.cc b/components/browser_sync/browser/profile_sync_service_unittest.cc
index 1c620ef08432f4b689480afa21897a16b5fe9f5f..c83b083c3f3550aeef485abd5d11abf0e71c0aed 100644
--- a/components/browser_sync/browser/profile_sync_service_unittest.cc
+++ b/components/browser_sync/browser/profile_sync_service_unittest.cc
@@ -625,8 +625,8 @@ TEST_F(ProfileSyncServiceTest, SignOutRevokeAccessToken) {
}
#endif
-// Verify that LastSyncedTime is cleared when the user signs out.
-TEST_F(ProfileSyncServiceTest, ClearLastSyncedTimeOnSignOut) {
+// Verify that LastSyncedTime and local DeviceInfo is cleared on sign out.
+TEST_F(ProfileSyncServiceTest, ClearDataOnSignOut) {
IssueTestTokens();
CreateService(ProfileSyncService::AUTO_START);
ExpectDataTypeManagerCreation(1, GetDefaultConfigureCalledCallback());
@@ -635,6 +635,7 @@ TEST_F(ProfileSyncServiceTest, ClearLastSyncedTimeOnSignOut) {
EXPECT_TRUE(service()->IsSyncActive());
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_SYNC_TIME_JUST_NOW),
service()->GetLastSyncedTimeString());
+ EXPECT_TRUE(service()->GetLocalDeviceInfoProvider()->GetLocalDeviceInfo());
// Sign out.
service()->RequestStop(ProfileSyncService::CLEAR_DATA);
@@ -642,6 +643,7 @@ TEST_F(ProfileSyncServiceTest, ClearLastSyncedTimeOnSignOut) {
EXPECT_EQ(l10n_util::GetStringUTF16(IDS_SYNC_TIME_NEVER),
service()->GetLastSyncedTimeString());
+ EXPECT_FALSE(service()->GetLocalDeviceInfoProvider()->GetLocalDeviceInfo());
}
// Verify that the disable sync flag disables sync.
« no previous file with comments | « components/browser_sync/browser/profile_sync_service.cc ('k') | components/sync_driver/local_device_info_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698