Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fwl/core/fwl_widgetmgrimp.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Manual tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fwl/basewidget/fwl_listboximp.cpp ('K') | « xfa/fwl/core/fwl_noteimp.cpp ('k') | xfa/fwl/theme/cfwl_checkboxtp.cpp » ('j') | xfa/fxfa/app/xfa_ffwidget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/fwl_widgetmgrimp.cpp
diff --git a/xfa/fwl/core/fwl_widgetmgrimp.cpp b/xfa/fwl/core/fwl_widgetmgrimp.cpp
index 02b63862e50bae575557e5967e89b8563d44dd8d..88accd5e7e03d793ba71c781be820e5ae971f64e 100644
--- a/xfa/fwl/core/fwl_widgetmgrimp.cpp
+++ b/xfa/fwl/core/fwl_widgetmgrimp.cpp
@@ -671,7 +671,7 @@ FX_BOOL CFWL_WidgetMgr::IsThreadEnabled() {
return !(m_dwCapability & FWL_WGTMGR_DisableThread);
}
FX_BOOL CFWL_WidgetMgr::IsFormDisabled() {
dsinclair 2016/05/04 13:11:51 nit: bool?
Tom Sepez 2016/05/04 20:21:26 Done.
- return m_dwCapability & FWL_WGTMGR_DisableForm;
+ return !!(m_dwCapability & FWL_WGTMGR_DisableForm);
}
FX_BOOL CFWL_WidgetMgr::GetAdapterPopupPos(IFWL_Widget* pWidget,
FX_FLOAT fMinHeight,
« xfa/fwl/basewidget/fwl_listboximp.cpp ('K') | « xfa/fwl/core/fwl_noteimp.cpp ('k') | xfa/fwl/theme/cfwl_checkboxtp.cpp » ('j') | xfa/fxfa/app/xfa_ffwidget.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698