Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fwl/basewidget/fwl_listboximp.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Manual tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fxge/ge/fx_ge_text.cpp ('K') | « xfa/fwl/basewidget/fwl_editimp.cpp ('k') | xfa/fwl/core/fwl_formimp.h » ('j') | xfa/fwl/core/fwl_widgetmgrimp.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/basewidget/fwl_listboximp.cpp
diff --git a/xfa/fwl/basewidget/fwl_listboximp.cpp b/xfa/fwl/basewidget/fwl_listboximp.cpp
index dd017e215ff5741351aa9e54ee4711ee4c2941c8..05a56fadac6a0de53d1384ba337c6353aebfc103 100644
--- a/xfa/fwl/basewidget/fwl_listboximp.cpp
+++ b/xfa/fwl/basewidget/fwl_listboximp.cpp
@@ -399,8 +399,7 @@ void CFWL_ListBoxImp::ClearSelection() {
for (int32_t i = 0; i < iCount; i++) {
FWL_HLISTITEM hItem = pData->GetItem(m_pInterface, i);
uint32_t dwState = pData->GetItemStyles(m_pInterface, hItem);
- FX_BOOL bFindSel = dwState & FWL_ITEMSTATE_LTB_Selected;
- if (!bFindSel) {
+ if (!(dwState & FWL_ITEMSTATE_LTB_Selected)) {
dsinclair 2016/05/04 13:11:51 nit: no {}'s
Tom Sepez 2016/05/04 20:21:25 Done.
continue;
}
SetSelectionDirect(hItem, FALSE);
« core/fxge/ge/fx_ge_text.cpp ('K') | « xfa/fwl/basewidget/fwl_editimp.cpp ('k') | xfa/fwl/core/fwl_formimp.h » ('j') | xfa/fwl/core/fwl_widgetmgrimp.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698