Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fxcrt/extension.h

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Manual tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fpdfapi/fpdf_render/fpdf_render_image.cpp ('K') | « core/fpdfapi/fpdf_render/fpdf_render_image.cpp ('k') | core/fxge/ge/fx_ge_text.cpp » ('j') | core/fxge/ge/fx_ge_text.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/extension.h
diff --git a/core/fxcrt/extension.h b/core/fxcrt/extension.h
index a8a099c664bb567f1d75bf623b4d4f028a1b1c30..b0e7b9e117ef519b65524001eb00cbc2ea3f5c7f 100644
--- a/core/fxcrt/extension.h
+++ b/core/fxcrt/extension.h
@@ -241,7 +241,7 @@ class CFX_MemoryStream final : public IFX_MemoryStream {
}
FX_BOOL Flush() override { return TRUE; }
FX_BOOL IsConsecutive() const override {
dsinclair 2016/05/04 13:11:50 Can this return bool now?
Tom Sepez 2016/05/04 20:21:25 Yes, but all the ripples ... didn't want to hunt d
- return m_dwFlags & FX_MEMSTREAM_Consecutive;
+ return !!(m_dwFlags & FX_MEMSTREAM_Consecutive);
}
void EstimateSize(size_t nInitSize, size_t nGrowSize) override {
if (m_dwFlags & FX_MEMSTREAM_Consecutive) {
« core/fpdfapi/fpdf_render/fpdf_render_image.cpp ('K') | « core/fpdfapi/fpdf_render/fpdf_render_image.cpp ('k') | core/fxge/ge/fx_ge_text.cpp » ('j') | core/fxge/ge/fx_ge_text.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698