Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: core/fpdfapi/fpdf_render/fpdf_render_image.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Manual tidy Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/fpdf_render/fpdf_render_image.cpp
diff --git a/core/fpdfapi/fpdf_render/fpdf_render_image.cpp b/core/fpdfapi/fpdf_render/fpdf_render_image.cpp
index 528ad78d2ba3b0a410d422b93f4ae96352c5b65e..e2ceecdfc07c2d61bf393a089818c7eba8bb0d1a 100644
--- a/core/fpdfapi/fpdf_render/fpdf_render_image.cpp
+++ b/core/fpdfapi/fpdf_render/fpdf_render_image.cpp
@@ -45,8 +45,8 @@ void CPDF_RenderStatus::CompositeDIBitmap(CFX_DIBitmap* pDIBitmap,
if (!pDIBitmap) {
return;
}
- FX_BOOL bIsolated = Transparency & PDFTRANS_ISOLATED;
- FX_BOOL bGroup = Transparency & PDFTRANS_GROUP;
+ FX_BOOL bIsolated = !!(Transparency & PDFTRANS_ISOLATED);
dsinclair 2016/05/04 13:11:50 Move these down to ~69 where they're first used?
Tom Sepez 2016/05/04 20:21:25 Done.
+ FX_BOOL bGroup = !!(Transparency & PDFTRANS_GROUP);
dsinclair 2016/05/04 13:11:50 nit: bool
Tom Sepez 2016/05/04 20:21:25 Done.
if (blend_mode == FXDIB_BLEND_NORMAL) {
if (!pDIBitmap->IsAlphaMask()) {
if (bitmap_alpha < 255) {

Powered by Google App Engine
This is Rietveld 408576698