core/fpdfapi/fpdf_render/fpdf_render.cpp - Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_render/fpdf_render.cpp

Issue 1951653002: Return bool rather than bitwise-and for FX_BOOL (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Manual tidy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_render/fpdf_render.cpp

diff --git a/core/fpdfapi/fpdf_render/fpdf_render.cpp b/core/fpdfapi/fpdf_render/fpdf_render.cpp

index 4f83370ad283542df840c244dbc1b6053a9de56d..ef3bc121f37c6c6b7eb87ade46123294974b0675 100644

--- a/core/fpdfapi/fpdf_render/fpdf_render.cpp

+++ b/core/fpdfapi/fpdf_render/fpdf_render.cpp

@@ -750,7 +750,7 @@ FX_BOOL CPDF_RenderStatus::ProcessTransparency(const CPDF_PageObject* pPageObj,

!bTextClip && !bGroupTransparent) {

return FALSE;

}

- FX_BOOL isolated = Transparency & PDFTRANS_ISOLATED;

+ FX_BOOL isolated = !!(Transparency & PDFTRANS_ISOLATED);

dsinclair 2016/05/04 13:11:50 nit: bool

Tom Sepez 2016/05/04 20:21:25 Done.

if (m_bPrint) {

FX_BOOL bRet = FALSE;

int rendCaps = m_pDevice->GetRenderCaps();