Expand GrStyle's interface.

Expand GrStyle's interface.

Adds some basic getters on GrStyle as well as static const instances for fill and hairline.

Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.

Moves style key functions from GrShape to GrStyle.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1951613002

Committed: https://skia.googlesource.com/skia/+/fb08327e592a1dd19a0c3107243ccd01f6b7f848

[bsalomon, 2016-05-03 22:16:50]

Description was changed from

==========
Expand GrStyle's interface.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
==========

to

==========
Expand GrStyle's interface.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-03 22:23:22]

Description was changed from

==========
Expand GrStyle's interface.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Expand GrStyle's interface.

Adds some basic getters on GrStyle as well as static const instances for fill
and hairline.

Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.

Moves style key functions from GrShape to GrStyle.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-05-03 22:47:29]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2016-05-03 22:47:30]

This is preparation for replacing GrStrokeInfo with GrStyle.

[bsalomon, 2016-05-03 23:59:36]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 23:59:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951613002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951613002/60001

[bsalomon, 2016-05-04 00:12:35]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 00:12:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951613002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951613002/120001

[commit-bot: I haz the power, 2016-05-04 00:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 00:25:19]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-05-04 13:49:38]

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp#ne...
src/gpu/GrShape.cpp:201: SkAssertResult(strokeRec.applyToPath(tmpPath.get(),
*fPath.get()));
can you not use fPath as both to src and dst here? Is there any reason to keep
the old path saved into tmpPath?

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp#ne...
src/gpu/GrShape.cpp:218:
SkAssertResult(parent.style().strokeRec().applyToPath(fPath.get(),
*srcForStrokeRec));
very nitty minor nit, but above you use fStyle and here you use style. Maybe be
consistent

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrStyle.cpp
File src/gpu/GrStyle.cpp (right):

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrStyle.cpp#ne...
src/gpu/GrStyle.cpp:143: *style = strokeRec.getStyle() ==
SkStrokeRec::kFill_Style
since you have the assert above why the need for the ternary here? Why not just
set it to strokeRec.getStyle()?

[bsalomon, 2016-05-04 14:29:17]

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp#ne...
src/gpu/GrShape.cpp:201: SkAssertResult(strokeRec.applyToPath(tmpPath.get(),
*fPath.get()));
On 2016/05/04 13:49:37, egdaniel wrote:
> can you not use fPath as both to src and dst here? Is there any reason to keep
> the old path saved into tmpPath?

No, that was a bug in the old code. Added a comment.

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp#ne...
src/gpu/GrShape.cpp:218:
SkAssertResult(parent.style().strokeRec().applyToPath(fPath.get(),
*srcForStrokeRec));
On 2016/05/04 13:49:37, egdaniel wrote:
> very nitty minor nit, but above you use fStyle and here you use style. Maybe
be
> consistent 

Done.

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrStyle.cpp
File src/gpu/GrStyle.cpp (right):

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrStyle.cpp#ne...
src/gpu/GrStyle.cpp:143: *style = strokeRec.getStyle() ==
SkStrokeRec::kFill_Style
On 2016/05/04 13:49:38, egdaniel wrote:
> since you have the assert above why the need for the ternary here? Why not
just
> set it to strokeRec.getStyle()?

That returns a SkStrokeRec::Style: 
    enum Style {
        kHairline_Style,
        kFill_Style,
        kStroke_Style,
        kStrokeAndFill_Style
    };

I need a SkStrokeRec::InitStyle:
    enum InitStyle {
        kHairline_InitStyle,
        kFill_InitStyle
    };


InitStyles are the styles that don't further apply to the geometry.

[bsalomon, 2016-05-04 14:56:20]

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrShape.cpp#ne...
src/gpu/GrShape.cpp:201: SkAssertResult(strokeRec.applyToPath(tmpPath.get(),
*fPath.get()));
On 2016/05/04 14:29:17, bsalomon wrote:
> On 2016/05/04 13:49:37, egdaniel wrote:
> > can you not use fPath as both to src and dst here? Is there any reason to
keep
> > the old path saved into tmpPath?
> 
> No, that was a bug in the old code. Added a comment.

Actually, you're right. There must have been a different bug. All the tests pass
of I stroke from fPath to fPath here. Changed.

[egdaniel, 2016-05-04 15:01:49]

lgtm

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrStyle.cpp
File src/gpu/GrStyle.cpp (right):

https://codereview.chromium.org/1951613002/diff/120001/src/gpu/GrStyle.cpp#ne...
src/gpu/GrStyle.cpp:143: *style = strokeRec.getStyle() ==
SkStrokeRec::kFill_Style
On 2016/05/04 14:29:17, bsalomon wrote:
> On 2016/05/04 13:49:38, egdaniel wrote:
> > since you have the assert above why the need for the ternary here? Why not
> just
> > set it to strokeRec.getStyle()?
> 
> That returns a SkStrokeRec::Style: 
>     enum Style {
>         kHairline_Style,
>         kFill_Style,
>         kStroke_Style,
>         kStrokeAndFill_Style
>     };
> 
> I need a SkStrokeRec::InitStyle:
>     enum InitStyle {
>         kHairline_InitStyle,
>         kFill_InitStyle
>     };
> 
> 
> InitStyles are the styles that don't further apply to the geometry.

Ah missed the Init part in there

[bsalomon, 2016-05-04 15:16:41]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-05-04 15:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951613002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951613002/160001

[commit-bot: I haz the power, 2016-05-04 15:27:45]

Description was changed from

==========
Expand GrStyle's interface.

Adds some basic getters on GrStyle as well as static const instances for fill
and hairline.

Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.

Moves style key functions from GrShape to GrStyle.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Expand GrStyle's interface.

Adds some basic getters on GrStyle as well as static const instances for fill
and hairline.

Adds the ability to apply a GrStyle to a SkPath to produce an output SkPath.

Moves style key functions from GrShape to GrStyle.

Also fixes some issues with SkPath creation when applying style to GrShapes.

Adds tests that GrShape produces the correct SkPath when its GrStyle is applied.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/fb08327e592a1dd19a0c3107243ccd01f6b7f848
==========

[commit-bot: I haz the power, 2016-05-04 15:27:46]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/fb08327e592a1dd19a0c3107243ccd01f6b7f848