Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: src/gpu/GrStyle.cpp

Issue 1951613002: Expand GrStyle's interface. (Closed) Base URL: https://chromium.googlesource.com/skia.git@style
Patch Set: Don't use temp for stroke in GrShape::GrShape() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrStyle.h ('k') | tests/GrShapeTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrStyle.cpp
diff --git a/src/gpu/GrStyle.cpp b/src/gpu/GrStyle.cpp
index 40a148bb4a9c6e88063d064aa3232ef6fda50202..7d70baa1bcda4fc7e7395e8d1481849236f28d88 100644
--- a/src/gpu/GrStyle.cpp
+++ b/src/gpu/GrStyle.cpp
@@ -7,27 +7,142 @@
#include "GrStyle.h"
+int GrStyle::KeySize(const GrStyle &style, Apply apply) {
+ GR_STATIC_ASSERT(sizeof(uint32_t) == sizeof(SkScalar));
+ int size = 0;
+ if (style.isDashed()) {
+ // One scalar for dash phase and one for each dash value.
+ size += 1 + style.dashIntervalCnt();
+ } else if (style.pathEffect()) {
+ // No key for a generic path effect.
+ return -1;
+ }
+
+ if (Apply::kPathEffectOnly == apply) {
+ return size;
+ }
+
+ if (style.strokeRec().needToApply()) {
+ // One for style/cap/join, 2 for miter and width.
+ size += 3;
+ }
+ return size;
+}
+
+void GrStyle::WriteKey(uint32_t *key, const GrStyle &style, Apply apply) {
+ SkASSERT(key);
+ SkASSERT(KeySize(style, apply) >= 0);
+ GR_STATIC_ASSERT(sizeof(uint32_t) == sizeof(SkScalar));
+
+ int i = 0;
+ if (style.isDashed()) {
+ GR_STATIC_ASSERT(sizeof(style.dashPhase()) == sizeof(uint32_t));
+ SkScalar phase = style.dashPhase();
+ memcpy(&key[i++], &phase, sizeof(SkScalar));
+
+ int32_t count = style.dashIntervalCnt();
+ // Dash count should always be even.
+ SkASSERT(0 == (count & 0x1));
+ const SkScalar *intervals = style.dashIntervals();
+ int intervalByteCnt = count * sizeof(SkScalar);
+ memcpy(&key[i], intervals, intervalByteCnt);
+ i += count;
+ } else {
+ SkASSERT(!style.pathEffect());
+ }
+
+ if (Apply::kPathEffectAndStrokeRec == apply && style.strokeRec().needToApply()) {
+ enum {
+ kStyleBits = 2,
+ kJoinBits = 2,
+ kCapBits = 32 - kStyleBits - kJoinBits,
+
+ kJoinShift = kStyleBits,
+ kCapShift = kJoinShift + kJoinBits,
+ };
+ GR_STATIC_ASSERT(SkStrokeRec::kStyleCount <= (1 << kStyleBits));
+ GR_STATIC_ASSERT(SkPaint::kJoinCount <= (1 << kJoinBits));
+ GR_STATIC_ASSERT(SkPaint::kCapCount <= (1 << kCapBits));
+ key[i++] = style.strokeRec().getStyle() |
+ style.strokeRec().getJoin() << kJoinShift |
+ style.strokeRec().getCap() << kCapShift;
+
+ SkScalar scalar;
+ // Miter limit only affects miter joins
+ scalar = SkPaint::kMiter_Join == style.strokeRec().getJoin()
+ ? style.strokeRec().getMiter()
+ : -1.f;
+ memcpy(&key[i++], &scalar, sizeof(scalar));
+
+ scalar = style.strokeRec().getWidth();
+ memcpy(&key[i++], &scalar, sizeof(scalar));
+ }
+ SkASSERT(KeySize(style, apply) == i);
+}
+
void GrStyle::initPathEffect(SkPathEffect* pe) {
+ SkASSERT(!fPathEffect)
+ SkASSERT(SkPathEffect::kNone_DashType == fDashInfo.fType);
+ SkASSERT(0 == fDashInfo.fIntervals.count());
if (!pe) {
- fDashInfo.fType = SkPathEffect::kNone_DashType;
return;
}
SkPathEffect::DashInfo info;
if (SkPathEffect::kDash_DashType == pe->asADash(&info)) {
- if (fStrokeRec.getStyle() == SkStrokeRec::kFill_Style) {
- fPathEffect.reset(nullptr);
- } else {
- fPathEffect.reset(SkSafeRef(pe));
+ if (fStrokeRec.getStyle() != SkStrokeRec::kFill_Style) {
fDashInfo.fType = SkPathEffect::kDash_DashType;
fDashInfo.fIntervals.reset(info.fCount);
fDashInfo.fPhase = info.fPhase;
info.fIntervals = fDashInfo.fIntervals.get();
pe->asADash(&info);
- return;
+ fPathEffect.reset(SkSafeRef(pe));
}
} else {
fPathEffect.reset(SkSafeRef(pe));
}
- fDashInfo.fType = SkPathEffect::kNone_DashType;
- fDashInfo.fIntervals.reset(0);
+}
+
+static inline bool apply_path_effect(SkPath* dst, SkStrokeRec* strokeRec,
+ const sk_sp<SkPathEffect>& pe, const SkPath& src) {
+ if (!pe) {
+ return false;
+ }
+ if (!pe->filterPath(dst, src, strokeRec, nullptr)) {
+ return false;
+ }
+ dst->setIsVolatile(true);
+ return true;
+}
+
+bool GrStyle::applyPathEffectToPath(SkPath *dst, SkStrokeRec *remainingStroke,
+ const SkPath &src) const {
+ SkASSERT(dst);
+ SkStrokeRec strokeRec = fStrokeRec;
+ if (!apply_path_effect(dst, &strokeRec, fPathEffect, src)) {
+ return false;
+ }
+ *remainingStroke = strokeRec;
+ return true;
+}
+
+bool GrStyle::applyToPath(SkPath* dst, SkStrokeRec::InitStyle* style, const SkPath& src) const {
+ SkASSERT(style);
+ SkASSERT(dst);
+ SkStrokeRec strokeRec = fStrokeRec;
+ if (!apply_path_effect(dst, &strokeRec, fPathEffect, src)) {
+ return false;
+ }
+ if (strokeRec.needToApply()) {
+ if (!strokeRec.applyToPath(dst, *dst)) {
+ return false;
+ }
+ *style = SkStrokeRec::kFill_InitStyle;
+ } else {
+ SkASSERT(SkStrokeRec::kFill_Style == strokeRec.getStyle() ||
+ SkStrokeRec::kHairline_Style == strokeRec.getStyle());
+ *style = strokeRec.getStyle() == SkStrokeRec::kFill_Style
+ ? SkStrokeRec::kFill_InitStyle
+ : SkStrokeRec::kHairline_InitStyle;
+ }
+ return true;
}
« no previous file with comments | « src/gpu/GrStyle.h ('k') | tests/GrShapeTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698