Explicitly test same/cross-origin importScripts() effect on worker.onerror.

Explicitly test same/cross-origin importScripts() effect on worker.onerror.

We currently have a single test that checks behavior when calling
importScripts() on a URL that redirects from same-origin to cross-origin.
This patch adds tests for cross-origin and same-origin scripts, and updates
the tests to use js-test-pre.js.

Currently we have some weird behavior for cross-origin scripts. The
message is sanitized, the URL is set to the worker JS file, and the line
number is the call to 'importScripts'.

Firefox has different weird behavior: the message is unsanitized, but
the URL and line number are emptied.

I think it's reasonable to leave the expectations as they are, but our
eventual goal should be to sanitize these errors in the same way that we
do normal cross-origin messages.

BUG=159566
R=ch.dumez@sisa.samsung.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154839

[Mike West, 2013-07-24 15:01:11]

Hi Christophe,

This is highly related to that other CL you're looking at, would you mind taking
a look?

Note in particular that I've changed js-test-pre.js, as it automagically hooks
window.onerror, which causes some problems for tests like these. :) That fix
will enable me to get rid of some of the FAIL messages you noted in
https://codereview.chromium.org/19962008/

Thanks!

-mike

[do-not-use, 2013-07-24 15:11:29]

LGTM.

https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resour...
File LayoutTests/http/tests/resources/js-test-pre.js (right):

https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resour...
LayoutTests/http/tests/resources/js-test-pre.js:75: if (!self.isOnErrorTest) {
nit: Should we update LayoutTests/fast/js/resources/js-test-pre.js as well for
consistency?

https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resour...
LayoutTests/http/tests/resources/js-test-pre.js:75: if (!self.isOnErrorTest) {
Should we update LayoutTests/fast/js/resources/js-test-pre.js as well for
consistency?

[Mike West, 2013-07-24 15:21:57]

Thanks!

https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resour...
File LayoutTests/http/tests/resources/js-test-pre.js (right):

https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resour...
LayoutTests/http/tests/resources/js-test-pre.js:75: if (!self.isOnErrorTest) {
On 2013/07/24 15:11:29, Christophe Dumez wrote:
> Should we update LayoutTests/fast/js/resources/js-test-pre.js as well for
> consistency?

We should, good idea. I'll add that.

[commit-bot: I haz the power, 2013-07-24 15:22:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/19514006/6001

[commit-bot: I haz the power, 2013-07-24 16:15:50]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-24 17:55:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/19514006/6001

[Mike West, 2013-07-24 18:18:11]

Committed patchset #3 manually as r154839 (presubmit successful).