Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(42)

Issue 19514006: Explicitly test same/cross-origin importScripts() effect on worker.onerror. (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
Reviewers:
do-not-use
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Explicitly test same/cross-origin importScripts() effect on worker.onerror. We currently have a single test that checks behavior when calling importScripts() on a URL that redirects from same-origin to cross-origin. This patch adds tests for cross-origin and same-origin scripts, and updates the tests to use js-test-pre.js. Currently we have some weird behavior for cross-origin scripts. The message is sanitized, the URL is set to the worker JS file, and the line number is the call to 'importScripts'. Firefox has different weird behavior: the message is unsanitized, but the URL and line number are emptied. I think it's reasonable to leave the expectations as they are, but our eventual goal should be to sanitize these errors in the same way that we do normal cross-origin messages. BUG=159566 R=ch.dumez@sisa.samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154839

Patch Set 1 #

Total comments: 3

Patch Set 2 : fast/js/js-test-pre.js #

Patch Set 3 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -46 lines) Patch
M LayoutTests/fast/js/resources/js-test-pre.js View 1 1 chunk +6 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/resources/js-test-pre.js View 1 chunk +6 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/workers/resources/worker-importScripts-error.js View 1 chunk +0 lines, -2 lines 0 comments Download
A LayoutTests/http/tests/workers/resources/worker-importscripts-onerror-crossorigin.js View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/http/tests/workers/resources/worker-importscripts-onerror-redirect-to-crossorigin.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/http/tests/workers/resources/worker-importscripts-onerror-sameorigin.js View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/workers/worker-importScripts-onerror-crossorigin-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/workers/worker-importScripts-onerror-redirect-to-crossorigin.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/workers/worker-importScripts-onerror-redirect-to-crossorigin-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/workers/worker-importScripts-onerror-sameorigin-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/workers/worker-importScriptsOnError.html View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
Hi Christophe, This is highly related to that other CL you're looking at, would you ...
5 years, 9 months ago (2013-07-24 15:01:11 UTC) #1
do-not-use
LGTM. https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resources/js-test-pre.js File LayoutTests/http/tests/resources/js-test-pre.js (right): https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resources/js-test-pre.js#newcode75 LayoutTests/http/tests/resources/js-test-pre.js:75: if (!self.isOnErrorTest) { nit: Should we update LayoutTests/fast/js/resources/js-test-pre.js ...
5 years, 9 months ago (2013-07-24 15:11:29 UTC) #2
Mike West
Thanks! https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resources/js-test-pre.js File LayoutTests/http/tests/resources/js-test-pre.js (right): https://codereview.chromium.org/19514006/diff/1/LayoutTests/http/tests/resources/js-test-pre.js#newcode75 LayoutTests/http/tests/resources/js-test-pre.js:75: if (!self.isOnErrorTest) { On 2013/07/24 15:11:29, Christophe Dumez ...
5 years, 9 months ago (2013-07-24 15:21:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/19514006/6001
5 years, 9 months ago (2013-07-24 15:22:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18252
5 years, 9 months ago (2013-07-24 16:15:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/19514006/6001
5 years, 9 months ago (2013-07-24 17:55:52 UTC) #6
Mike West
5 years, 9 months ago (2013-07-24 18:18:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r154839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698