Pickup latest analyzer fixes

Pickup latest analyzer fixes

Note the new errors in sdk.  Did we change something wrt overrides?

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/3f8d35910393e8289a43b7aa6d48e62b0eae335e

[vsm, 2016-05-05 22:52:17]

Description was changed from

==========
Pickup latest analyzer fixes
==========

to

==========
Pickup latest analyzer fixes

Note the new errors in sdk.  Did we change something wrt overrides?
==========

[vsm, 2016-05-05 22:52:17]

vsm@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[Leaf, 2016-05-05 23:03:59]

https://codereview.chromium.org/1951263004/diff/20001/tool/sdk_expected_error...
File tool/sdk_expected_errors.txt (right):

https://codereview.chromium.org/1951263004/diff/20001/tool/sdk_expected_error...
tool/sdk_expected_errors.txt:2: [error] Base class introduces an invalid
override. The type of JSArray.[]= ((int, E) → void) is not a subtype of
JSMutableIndexable.[]= ((int, dynamic) → dynamic).
(dart:_interceptors/js_array.dart, line 576, col 25)
These are because of a fix I made.  When we checked overrides, we were treating
(dynamic) -> dynamic as fuzzy.  So you got that weird co-variance, where you
could override an (dynamic) -> dynamic with an (int) -> int, but you couldn't
override an int -> dynamic with a dynamic -> dynamic.  We weren't implementing
the dsend on method calls of dynamic (which we would have to do to make this
sound), and I think the general sense was that there was no reason to treat
these as fuzzy arrows.

[Leaf, 2016-05-05 23:04:30]

lgtm

[vsm, 2016-05-05 23:30:45]

Description was changed from

==========
Pickup latest analyzer fixes

Note the new errors in sdk.  Did we change something wrt overrides?
==========

to

==========
Pickup latest analyzer fixes

Note the new errors in sdk.  Did we change something wrt overrides?

R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/3f8d35910393e8289a43b7aa6d48...
==========

[vsm, 2016-05-05 23:30:46]

Committed patchset #2 (id:20001) manually as
3f8d35910393e8289a43b7aa6d48e62b0eae335e (presubmit successful).