Pickup latest analyzer fixes

tool/sdk_expected_errors.txt

Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index f373361190aa888e6f2e6a108a066008da1cd7db..d72b406205066acb38e9636a7e4cd591c7a56c79 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -1,14 +1,36 @@
 [error] The argument type 'InternalMap' cannot be assigned to the parameter type 'Map'. (dart:_isolate_helper/isolate_serialization.dart, line 47, col 47)
-[error] Missing concrete implementation of 'num.==' (dart:_interceptors/js_number.dart, line 12, col 7)
-[error] Missing concrete implementation of 'String.==' (dart:_interceptors/js_string.dart, line 14, col 7)
+[error] Base class introduces an invalid override. The type of JSArray.[]= ((int, E) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:_interceptors/js_array.dart, line 576, col 25)

[Leaf, 2016/05/05 23:03:59]

These are because of a fix I made.  When we checked overrides, we were treating
(dynamic) -> dynamic as fuzzy.  So you got that weird co-variance, where you
could override an (dynamic) -> dynamic with an (int) -> int, but you couldn't
override an int -> dynamic with a dynamic -> dynamic.  We weren't implementing
the dsend on method calls of dynamic (which we would have to do to make this
sound), and I think the general sense was that there was no reason to treat
these as fuzzy arrows. 

+[error] Invalid override. The type of NativeTypedArrayOfDouble.[]= ((int, num) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:_native_typed_data, line 897, col 3)
+[error] Invalid override. The type of _JsonStringStringifierPretty.writeIndentation ((int) → void) is not a subtype of _JsonPrettyPrintMixin.writeIndentation ((dynamic) → void). (dart:convert/json.dart, line 875, col 3)
+[error] Invalid override. The type of _JsonUtf8StringifierPretty.writeIndentation ((int) → void) is not a subtype of _JsonPrettyPrintMixin.writeIndentation ((dynamic) → void). (dart:convert/json.dart, line 1034, col 3)
+[error] Invalid override. The type of DateTime.compareTo ((DateTime) → int) is not a subtype of Comparable<dynamic>.compareTo ((dynamic) → int). (dart:core/date_time.dart, line 412, col 3)
 [error] Annotation can be only constant variable or constant constructor invocation (dart:core/stacktrace.dart, line 27, col 3)
+[error] Invalid override. The type of FileList.[]= ((int, File) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 16869, col 3)
+[error] Invalid override. The type of HtmlCollection.[]= ((int, Node) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 18904, col 3)
+[error] Invalid override. The type of MimeTypeArray.[]= ((int, MimeType) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 23818, col 3)
+[error] Invalid override. The type of NodeList.[]= ((int, Node) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 25467, col 3)
+[error] Invalid override. The type of PluginArray.[]= ((int, Plugin) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 26971, col 3)
+[error] Invalid override. The type of SourceBufferList.[]= ((int, SourceBuffer) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 30209, col 3)
+[error] Invalid override. The type of SpeechGrammarList.[]= ((int, SpeechGrammar) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 30410, col 3)
+[error] Invalid override. The type of TextTrackList.[]= ((int, TextTrack) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 32569, col 3)
+[error] Invalid override. The type of TouchList.[]= ((int, Touch) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 32904, col 3)
+[error] The return type '_ElementEventStreamImpl<Event>' is not a 'ElementStream<BeforeUnloadEvent>', as defined by the method 'forElement'. (dart:html, line 36588, col 12)
+[error] The return type '_ElementListEventStreamImpl<Event>' is not a 'ElementStream<BeforeUnloadEvent>', as defined by the method '_forElementList'. (dart:html, line 36593, col 12)
+[error] Invalid override. The type of _CssRuleList.[]= ((int, CssRule) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 37675, col 3)
+[error] Invalid override. The type of _GamepadList.[]= ((int, Gamepad) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 37929, col 3)
+[error] Invalid override. The type of _NamedNodeMap.[]= ((int, Node) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 38136, col 3)
+[error] Invalid override. The type of _SpeechRecognitionResultList.[]= ((int, SpeechRecognitionResult) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 38352, col 3)
+[error] Invalid override. The type of _StyleSheetList.[]= ((int, StyleSheet) → void) is not a subtype of JSMutableIndexable.[]= ((int, dynamic) → dynamic). (dart:html, line 38416, col 3)
+[error] The return type '_ElementListEventStreamImpl<Event>' is not a 'ElementStream<T>', as defined by the method '_forElementList'. (dart:html, line 39935, col 12)
 [error] Invalid override. The type of _EventStreamSubscription.asFuture (([dynamic]) → Future<dynamic>) is not a subtype of StreamSubscription<T>.asFuture (<E>([E]) → Future<E>). (dart:html, line 40153, col 3)
+[error] The return type '_WrappedIterator<Node>' is not a 'Iterator<E>', as defined by the method 'iterator'. (dart:html, line 42531, col 31)
 [error] The part was not supplied as an input to the compiler. (dart:html_common/conversions.dart, line 1, col 1)
 [error] The part was not supplied as an input to the compiler. (dart:html_common/conversions_dart2js.dart, line 1, col 1)
 [error] The part was not supplied as an input to the compiler. (dart:html_common/css_class_set.dart, line 1, col 1)
 [error] The part was not supplied as an input to the compiler. (dart:html_common/device.dart, line 1, col 1)
 [error] The part was not supplied as an input to the compiler. (dart:html_common/filtered_element_list.dart, line 1, col 1)
 [error] The part was not supplied as an input to the compiler. (dart:html_common/lists.dart, line 1, col 1)
+[error] Invalid override. The type of JsArray.[]= ((Object, E) → void) is not a subtype of JsObject.[]= ((Object, dynamic) → dynamic). (dart:js, line 363, col 3)
 [warning] Unsound implicit cast from dynamic to List<String> (dart:_debugger, line 24, col 45)
 [warning] Unsound implicit cast from dynamic to List<String> (dart:_isolate_helper, line 839, col 37)
 [warning] Unsound implicit cast from dynamic to List<String> (dart:_isolate_helper, line 886, col 11)
@@ -190,33 +212,14 @@
 [warning] Unsound implicit cast from dynamic to Rectangle<num> (dart:html, line 37635, col 14)
 [warning] Unsound implicit cast from (T) → void to (Event) → dynamic (dart:html, line 40091, col 67)
 [warning] Unsound implicit cast from (T) → void to (Event) → dynamic (dart:html, line 40113, col 45)
-[warning] Unsound implicit cast from num to T (dart:math, line 85, col 16)
-[warning] Unsound implicit cast from num to T (dart:math, line 120, col 16)
-[warning] Unsound implicit cast from num to T (dart:math/point.dart, line 37, col 25)
-[warning] Unsound implicit cast from num to T (dart:math/point.dart, line 37, col 38)
-[warning] Unsound implicit cast from num to T (dart:math/point.dart, line 46, col 25)
-[warning] Unsound implicit cast from num to T (dart:math/point.dart, line 46, col 38)
+[warning] Unsound implicit cast from From to To (dart:html, line 42594, col 70)
+[warning] Unsound implicit cast from dynamic to To (dart:indexed_db, line 1205, col 37)
 [warning] Unsound implicit cast from num to T (dart:math/point.dart, line 59, col 25)
 [warning] Unsound implicit cast from num to T (dart:math/point.dart, line 59, col 37)
-[warning] Unsound implicit cast from num to T (dart:math/point.dart, line 86, col 12)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 33, col 18)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 35, col 19)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 68, col 41)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 68, col 50)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 95, col 40)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 95, col 54)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 119, col 41)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 120, col 44)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 121, col 7)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 123, col 7)
 [warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 151, col 22)
 [warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 152, col 23)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 168, col 15)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 170, col 16)
 [warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 212, col 23)
 [warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 213, col 24)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 229, col 15)
-[warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 231, col 16)
 [warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 247, col 28)
 [warning] Unsound implicit cast from num to T (dart:math/rectangle.dart, line 263, col 30)
 [warning] The final variables 'href' and 'target' must be initialized (dart:svg, line 60, col 3)