Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1951233003: Consistent SignedCertificateTimestamp::Version and SignedTreeHead::Version (Closed)

Created:
4 years, 7 months ago by Rob Percival
Modified:
4 years, 7 months ago
Reviewers:
eroman, Eran Messeri, estark
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistent SignedCertificateTimestamp::Version and SignedTreeHead::Version BUG=608868 Committed: https://crrev.com/4dccdbbb4deb5e110df1bb0bf2dc736b3d944448 Cr-Commit-Position: refs/heads/master@{#392302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_objects_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_serialization.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/cert/signed_certificate_timestamp.h View 1 chunk +1 line, -1 line 0 comments Download
M net/test/ct_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
Rob Percival
4 years, 7 months ago (2016-05-05 17:08:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951233003/1
4 years, 7 months ago (2016-05-05 17:59:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 20:00:32 UTC) #6
Eran Messeri
lgtm, thanks for making this code consistent.
4 years, 7 months ago (2016-05-05 20:01:58 UTC) #7
Rob Percival
4 years, 7 months ago (2016-05-05 20:06:17 UTC) #9
eroman
lgtm
4 years, 7 months ago (2016-05-06 23:37:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951233003/1
4 years, 7 months ago (2016-05-07 13:02:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/179316)
4 years, 7 months ago (2016-05-07 13:07:52 UTC) #14
Rob Percival
Emily, could you give this a quick look and LGTM as an owner of chrome/browser/ssl ...
4 years, 7 months ago (2016-05-07 23:00:13 UTC) #16
estark
//c/b/ssl lgtm
4 years, 7 months ago (2016-05-09 11:55:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951233003/1
4 years, 7 months ago (2016-05-09 12:36:40 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 13:49:00 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 13:50:26 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4dccdbbb4deb5e110df1bb0bf2dc736b3d944448
Cr-Commit-Position: refs/heads/master@{#392302}

Powered by Google App Engine
This is Rietveld 408576698