net/cert/ct_objects_extractor_unittest.cc - Issue 1951233003: Consistent SignedCertificateTimestamp::Version and SignedTreeHead::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/ct_objects_extractor_unittest.cc

Issue 1951233003: Consistent SignedCertificateTimestamp::Version and SignedTreeHead::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/ct_objects_extractor_unittest.cc

diff --git a/net/cert/ct_objects_extractor_unittest.cc b/net/cert/ct_objects_extractor_unittest.cc

index 5bb59ba3db0f8c5a10363c45fc86cfae37aac074..4857f582ad30b09b29fbe366df334a5ea2474f52 100644

--- a/net/cert/ct_objects_extractor_unittest.cc

+++ b/net/cert/ct_objects_extractor_unittest.cc

@@ -62,7 +62,7 @@ TEST_F(CTObjectsExtractorTest, ExtractEmbeddedSCT) {

new ct::SignedCertificateTimestamp());

ExtractEmbeddedSCT(precert_chain_[0], &sct);

- EXPECT_EQ(sct->version, SignedCertificateTimestamp::SCT_VERSION_1);

+ EXPECT_EQ(sct->version, SignedCertificateTimestamp::V1);

EXPECT_EQ(ct::GetTestPublicKeyId(), sct->log_id);

base::Time expected_timestamp =

« no previous file with comments | « chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc ('k') | net/cert/ct_serialization.cc » ('j') | no next file with comments »