Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 1951053004: Prevent leaking RenderProcessHosts from PasswordManagerHandlerTest. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent leaking RenderProcessHosts from PasswordManagerHandlerTest. PasswordManagerHandlerTest should extend ChromeRenderViewHostTestHarness so that it can create a TestWebContents without accidentally creating a real RenderProcessHost. If this happens it is leaked to later tests running in the same process and results in all kinds of nasty and hard to track down use-after-frees. BUG=608064 Committed: https://crrev.com/d49993d2c1a4a26f9f35dfe41c32b17e09d79ae0 Cr-Commit-Position: refs/heads/master@{#391839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M chrome/browser/ui/webui/options/password_manager_handler_unittest.cc View 6 chunks +19 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 7 months ago (2016-05-04 22:58:58 UTC) #2
Dan Beam
lgtm
4 years, 7 months ago (2016-05-05 17:45:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951053004/1
4 years, 7 months ago (2016-05-05 17:46:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 17:55:30 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 17:56:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d49993d2c1a4a26f9f35dfe41c32b17e09d79ae0
Cr-Commit-Position: refs/heads/master@{#391839}

Powered by Google App Engine
This is Rietveld 408576698