[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

R=avi@chromium.org
BUG=609154
Committed: https://crrev.com/f50d06aa929323e7c510f81064e11ec63ca0eecd
Cr-Commit-Position: refs/heads/master@{#391654}

[shrike, 2016-05-04 16:49:18]

Description was changed from

==========
[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

BUG=609154
==========

to

==========
[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

R=avi@chromium.org
BUG=609154
==========

[shrike, 2016-05-04 16:49:18]

shrike@chromium.org changed reviewers:
+ avi@chromium.org

[shrike, 2016-05-04 16:49:27]

PTAL

[Avi (use Gerrit), 2016-05-04 16:56:49]

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
File
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
(right):

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39:
}
Is there any way you can share the code that sets things up? Right now, if the
LocationBar code changes, this test will then be setting things up the wrong
way.

[shrike, 2016-05-04 17:30:42]

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
File
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
(right):

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39:
}
On 2016/05/04 16:56:49, Avi wrote:
> Is there any way you can share the code that sets things up? Right now, if the
> LocationBar code changes, this test will then be setting things up the wrong
> way.

That's a good point. But the only way to do that is to put code into
SelectedKeywordDecoration specifically to accommodate the test, which is kind of
ugly. I think I would have to modify the existing constructor.

Another way to go would be to modify LocationBarViewMac with a method that
initializes a passed-in SelectedKeywordDecoration, which is also kind of ugly.

[Avi (use Gerrit), 2016-05-04 18:03:18]

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
File
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
(right):

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39:
}
On 2016/05/04 17:30:42, shrike wrote:
> On 2016/05/04 16:56:49, Avi wrote:
> > Is there any way you can share the code that sets things up? Right now, if
the
> > LocationBar code changes, this test will then be setting things up the wrong
> > way.
> 
> That's a good point. But the only way to do that is to put code into
> SelectedKeywordDecoration specifically to accommodate the test, which is kind
of
> ugly. I think I would have to modify the existing constructor.
> 
> Another way to go would be to modify LocationBarViewMac with a method that
> initializes a passed-in SelectedKeywordDecoration, which is also kind of ugly.

Can you at least put in a reference to this test in LocationBar, so that if we
modify it we know to change this test too?

[shrike, 2016-05-04 21:05:34]

PTAL

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
File
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
(right):

https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39:
}
On 2016/05/04 18:03:18, Avi wrote:
> On 2016/05/04 17:30:42, shrike wrote:
> > On 2016/05/04 16:56:49, Avi wrote:
> > > Is there any way you can share the code that sets things up? Right now, if
> the
> > > LocationBar code changes, this test will then be setting things up the
wrong
> > > way.
> > 
> > That's a good point. But the only way to do that is to put code into
> > SelectedKeywordDecoration specifically to accommodate the test, which is
kind
> of
> > ugly. I think I would have to modify the existing constructor.
> > 
> > Another way to go would be to modify LocationBarViewMac with a method that
> > initializes a passed-in SelectedKeywordDecoration, which is also kind of
ugly.
> 
> Can you at least put in a reference to this test in LocationBar, so that if we
> modify it we know to change this test too?

I added some documentation there and to SelectedKeywordDecoration.

[Avi (use Gerrit), 2016-05-04 21:10:14]

lgtm

[shrike, 2016-05-04 21:15:45]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:16:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951033003/20001

[commit-bot: I haz the power, 2016-05-04 22:11:38]

Description was changed from

==========
[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

R=avi@chromium.org
BUG=609154
==========

to

==========
[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

R=avi@chromium.org
BUG=609154
==========

[commit-bot: I haz the power, 2016-05-04 22:11:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 22:12:41]

Description was changed from

==========
[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

R=avi@chromium.org
BUG=609154
==========

to

==========
[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

The decoration's image is no longer set in the constructor. A nil image
causes the tests to fail.

R=avi@chromium.org
BUG=609154

Committed: https://crrev.com/f50d06aa929323e7c510f81064e11ec63ca0eecd
Cr-Commit-Position: refs/heads/master@{#391654}
==========

[commit-bot: I haz the power, 2016-05-04 22:12:42]

Patchset 2 (id:??) landed as
https://crrev.com/f50d06aa929323e7c510f81064e11ec63ca0eecd
Cr-Commit-Position: refs/heads/master@{#391654}