Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1951033003: [Mac][Material Design] Fix SelectedKeywordDecoration tests for MD. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix SelectedKeywordDecoration tests for MD. The decoration's image is no longer set in the constructor. A nil image causes the tests to fail. R=avi@chromium.org BUG=609154 Committed: https://crrev.com/f50d06aa929323e7c510f81064e11ec63ca0eecd Cr-Commit-Position: refs/heads/master@{#391654}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-04 16:49:27 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm (right): https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm#newcode39 chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39: } Is there any way you can share the ...
4 years, 7 months ago (2016-05-04 16:56:49 UTC) #4
shrike
https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm (right): https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm#newcode39 chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39: } On 2016/05/04 16:56:49, Avi wrote: > Is there ...
4 years, 7 months ago (2016-05-04 17:30:42 UTC) #5
Avi (use Gerrit)
https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm (right): https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm#newcode39 chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39: } On 2016/05/04 17:30:42, shrike wrote: > On 2016/05/04 ...
4 years, 7 months ago (2016-05-04 18:03:18 UTC) #6
shrike
PTAL https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm (right): https://codereview.chromium.org/1951033003/diff/1/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm#newcode39 chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm:39: } On 2016/05/04 18:03:18, Avi wrote: > On ...
4 years, 7 months ago (2016-05-04 21:05:34 UTC) #7
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-04 21:10:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951033003/20001
4 years, 7 months ago (2016-05-04 21:16:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 22:11:39 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 22:12:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f50d06aa929323e7c510f81064e11ec63ca0eecd
Cr-Commit-Position: refs/heads/master@{#391654}

Powered by Google App Engine
This is Rietveld 408576698