chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm - Issue 1951033003: [Mac][Material Design] Fix SelectedKeywordDecoration tests for MD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm

Issue 1951033003: [Mac][Material Design] Fix SelectedKeywordDecoration tests for MD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add documentation. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm b/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm

index 1a797fed4cfa758a111a96d6ec20f558ea27e49e..97522b5843d31bfd9fe36aec8d997e514be2857a 100644

--- a/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm

@@ -21,6 +21,14 @@ SelectedKeywordDecoration::SelectedKeywordDecoration() {

SetTextColor([NSColor blackColor]);

return;

}

+ // Note: the unit test

+ // SelectedKeywordDecorationTest.UsesPartialKeywordIfNarrow expects to work

+ // with a fully-initialized SelectedKeywordDecoration (i.e. one that has a

+ // text color and image). During ordinary operation,

+ // LocationBarViewMac::Layout() sets the image before the decoration is

+ // actually used, which the unit test does as well. If

+ // SelectedKeywordDecoration's initialization process changes, the unit test

+ // should also be updated.

SetTextColor(GetBackgroundBorderColor());

}