Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 1950943002: [Sheriff] Fix WebViewLayoutTest regarding global interface expectations. (Closed)

Created:
4 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 7 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sheriff] Fix WebViewLayoutTest regarding global interface expectations. The expectation file assume speechSynthesis is an attribute but its now a getter. BUG=609100 R=timvolodine@chromium.org Committed: https://crrev.com/e3168773cb69e2a78acce39d1b4c1adbf56cac87 Cr-Commit-Position: refs/heads/master@{#391504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950943002/1
4 years, 7 months ago (2016-05-04 13:15:53 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 13:58:20 UTC) #4
timvolodine
yes looks like due to https://codereview.chromium.org/1380503002 lgtm, thanks!
4 years, 7 months ago (2016-05-04 14:24:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950943002/1
4 years, 7 months ago (2016-05-04 14:26:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 14:30:49 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3168773cb69e2a78acce39d1b4c1adbf56cac87 Cr-Commit-Position: refs/heads/master@{#391504}
4 years, 7 months ago (2016-05-04 14:31:57 UTC) #10
gsennton
4 years, 7 months ago (2016-05-09 16:02:08 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1960923003/ by gsennton@chromium.org.

The reason for reverting is: Fix WebViewLayoutTest failures due to
https://codereview.chromium.org/1380503002 being reverted.

Thus, to fix this we need to revert the current CL and
https://codereview.chromium.org/1951253003

BUG=609448.

Powered by Google App Engine
This is Rietveld 408576698