Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1950923002: Roll buildtools cdbd50759b..3092893157 (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools cdbd50759b..3092893157 In order to roll GN 6d7b5d9014..32be261298 (r389592:r391459) and pick up the following changes: 6ee04b5 [GN] Add support for generating Xcode projects. 0785c95 GN: forward_variables_from shouldn't clobber vars. cc00b40 GN: Add common header extensions c86fe93 GN: fix bootstrap f2347fc gn: Stop printing all help when the command is unknown d4fed18 Renaming system.gyp:ssl to system.gyp:nss and removing unused BUILD.gn b68180a Fix arm detection code in gn. f9f7d62 Add manifests to many more gn built exe files TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix build/toolchain/gcc_toolchain.gni #

Patch Set 4 : Fix build/toolchain/nacl_toolchain.gni #

Patch Set 5 : Rebase on https://codereview.chromium.org/1950643003/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
sdefresne
4 years, 7 months ago (2016-05-04 08:35:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950923002/1
4 years, 7 months ago (2016-05-04 08:35:47 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_gn_x64_rel on tryserver.chromium.win (JOB_FAILED, no build URL)
4 years, 7 months ago (2016-05-04 08:36:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950923002/60001
4 years, 7 months ago (2016-05-04 15:27:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950923002/80001
4 years, 7 months ago (2016-05-10 08:03:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/2906) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-10 08:04:52 UTC) #12
sdefresne
4 years, 7 months ago (2016-05-10 08:05:32 UTC) #14
Message was sent while issue was closed.
On 2016/05/10 08:05:02, sdefresne wrote:
> The CQ bit was unchecked by mailto:sdefresne@chromium.org

Ah, patch failures. Will relaunch the tool as this is one is probably obsolete.

Powered by Google App Engine
This is Rietveld 408576698