Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: tests/standalone/io/raw_server_socket_cancel_test.dart

Issue 19509004: Fix raw_server_socket_cancel_test on macos by always call close on done. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/raw_server_socket_cancel_test.dart
diff --git a/tests/standalone/io/raw_server_socket_cancel_test.dart b/tests/standalone/io/raw_server_socket_cancel_test.dart
index b32b535f7a2dfa7636ed36c4a6db48a931fb6bd2..a927c7cd02dd0dc939ac2cd034f0ab5483babc6e 100644
--- a/tests/standalone/io/raw_server_socket_cancel_test.dart
+++ b/tests/standalone/io/raw_server_socket_cancel_test.dart
@@ -26,6 +26,9 @@ void testCancelResubscribeServerSocket(int socketCount, int backlog) {
void checkDone() {
if (doneCount + errorCount + earlyErrorCount == socketCount) {
port.close();
+ // Be sure to close as subscription.cancel may not be called, if
+ // backlog prevents acceptCount to grow to socketCount / 2.
+ socket.close();
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698