Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: tests/standalone/io/raw_server_socket_cancel_test.dart

Issue 19509004: Fix raw_server_socket_cancel_test on macos by always call close on done. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // VMOptions= 5 // VMOptions=
6 // VMOptions=--short_socket_read 6 // VMOptions=--short_socket_read
7 // VMOptions=--short_socket_write 7 // VMOptions=--short_socket_write
8 // VMOptions=--short_socket_read --short_socket_write 8 // VMOptions=--short_socket_read --short_socket_write
9 9
10 import "package:expect/expect.dart"; 10 import "package:expect/expect.dart";
11 import "dart:async"; 11 import "dart:async";
12 import "dart:io"; 12 import "dart:io";
13 import "dart:isolate"; 13 import "dart:isolate";
14 14
15 void testCancelResubscribeServerSocket(int socketCount, int backlog) { 15 void testCancelResubscribeServerSocket(int socketCount, int backlog) {
16 var acceptCount = 0; 16 var acceptCount = 0;
17 var doneCount = 0; 17 var doneCount = 0;
18 var errorCount = 0; 18 var errorCount = 0;
19 var earlyErrorCount = 0; 19 var earlyErrorCount = 0;
20 20
21 ReceivePort port = new ReceivePort(); 21 ReceivePort port = new ReceivePort();
22 22
23 RawServerSocket.bind("127.0.0.1", 0, backlog: backlog).then((server) { 23 RawServerSocket.bind("127.0.0.1", 0, backlog: backlog).then((server) {
24 Expect.isTrue(server.port > 0); 24 Expect.isTrue(server.port > 0);
25 25
26 void checkDone() { 26 void checkDone() {
27 if (doneCount + errorCount + earlyErrorCount == socketCount) { 27 if (doneCount + errorCount + earlyErrorCount == socketCount) {
28 port.close(); 28 port.close();
29 // Be sure to close as subscription.cancel may not be called, if
30 // backlog prevents acceptCount to grow to socketCount / 2.
31 socket.close();
29 } 32 }
30 } 33 }
31 34
32 var subscription; 35 var subscription;
33 subscription = server.listen((client) { 36 subscription = server.listen((client) {
34 client.writeEventsEnabled = false; 37 client.writeEventsEnabled = false;
35 client.listen((event) { 38 client.listen((event) {
36 switch(event) { 39 switch(event) {
37 case RawSocketEvent.READ: 40 case RawSocketEvent.READ:
38 client.read(); 41 client.read();
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 checkDone(); 103 checkDone();
101 }); 104 });
102 } 105 }
103 }); 106 });
104 } 107 }
105 108
106 void main() { 109 void main() {
107 testCancelResubscribeServerSocket(10, 20); 110 testCancelResubscribeServerSocket(10, 20);
108 testCancelResubscribeServerSocket(20, 5); 111 testCancelResubscribeServerSocket(20, 5);
109 } 112 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698